From: Johannes Berg <johannes@sipsolutions.net>
To: Jiri Pirko <jpirko@redhat.com>
Cc: Netdev <netdev@vger.kernel.org>
Subject: Re: [RFC] net: refactor multicast/unicast address list
Date: Tue, 16 Jun 2009 13:29:31 +0200 [thread overview]
Message-ID: <1245151771.9256.3.camel@johannes.local> (raw)
In-Reply-To: <20090616111842.GG3521@psychotron.englab.brq.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]
On Tue, 2009-06-16 at 13:18 +0200, Jiri Pirko wrote:
> Sat, Jun 13, 2009 at 02:28:14PM CEST, johannes@sipsolutions.net wrote:
> >On Sat, 2009-06-13 at 12:41 +0200, Johannes Berg wrote:
> >> I'm trying to use address lists without netdevs, but as
> >> a first step I thought it would be good to reduce the
> >> amount duplicated code between unicast and multicast
> >> lists.
> >>
> >> After introducing a new 'struct address_list', we can
> >> unify a lot between these. The next step will probably
> >> be exporting the __dev_addr_sync and __dev_addr_unsync
> >> functions so I can use them without a netdev, but this
> >> cleanup can stand on its own.
> >
> >Sorry, this was based against the wrong tree and now I see that in
> >net-next the lists have diverged significantly. Ignore this.
>
> Yes, I've already converted unicast lists to use list_head there. I'm sending
> the patch doing the same for multicast lists soon.
Very nice! After that maybe I'll take a look again at moving things into
a common structure -- I ultimately want to use a multicast list without
a netdev to sync multiple netdevs onto a common multicast list that is
not part of a netdev.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-06-16 11:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 10:41 [RFC] net: refactor multicast/unicast address list Johannes Berg
2009-06-13 12:28 ` Johannes Berg
2009-06-16 11:18 ` Jiri Pirko
2009-06-16 11:29 ` Johannes Berg [this message]
2009-06-16 12:38 ` Jiri Pirko
[not found] ` <20090616123808.GK3521-YzwxZg+R7evSU73v1vjTzyO4YDw3rz4rAInAS/Ez/D0@public.gmane.org>
2009-06-16 23:09 ` Johannes Berg
[not found] ` <1245193788.21287.66.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-16 23:19 ` Johannes Berg
2009-06-17 7:21 ` Jiri Pirko
[not found] ` <20090617072100.GA3492-YzwxZg+R7evSU73v1vjTzyO4YDw3rz4rAInAS/Ez/D0@public.gmane.org>
2009-06-17 9:30 ` Johannes Berg
[not found] ` <1245231024.19769.0.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-17 12:26 ` John W. Linville
2009-06-17 12:58 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245151771.9256.3.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).