* [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o]
@ 2009-06-11 3:37 Subrata Modak
2009-06-15 6:51 ` Subrata Modak
0 siblings, 1 reply; 9+ messages in thread
From: Subrata Modak @ 2009-06-11 3:37 UTC (permalink / raw)
To: Tony Breeds, netdev, michael, Li Yang, Stephen Rothwell,
Nathan Lynch
Cc: Sachin P Sant, Linux-Next, Linux-Kernel, Subrata Modak,
Balbir Singh, Linuxppc-dev
Hi Nathan,
>On Wed, 2009-06-10 at 21:28 -0500, Nathan Lynch wrote:
>Subrata Modak <subrata@linux.vnet.ibm.com> writes:
>
> > On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote:
> >> Hi Subrata,
> >>
> >> On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak <subrata@linux.vnet.ibm.com> wrote:
> >> >
> >> > /* Find the TBI PHY. If it's not there, we don't support SGMII */
> >> > - ph = of_get_property(np, "tbi-handle", NULL);
> >> > + ph = (phandle *)of_get_property(np, "tbi-handle", NULL);
> >>
> >> You don't need this cast because of_get_property() returns "void *".
> >
> > Stephen,
> >
> > True. But without this gcc complains:
> >
> > CC [M] drivers/net/ucc_geth.o
> > drivers/net/ucc_geth.c: In function ‘ucc_geth_probe’:
> > drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers
> > from pointer target type
>
> ph should be declared const phandle *. Look at other uses of
> of_get_property.
>
Ok fine. Here is a revised patch again.
Subject: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o]
Reference(s):
http://lkml.org/lkml/2009/6/4/241,
http://lkml.org/lkml/2009/6/10/338,
Fix the following build error:
drivers/net/ucc_geth.c: In function bucc_geth_probeb:
drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function)
drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once
drivers/net/ucc_geth.c:3822: error: for each function it appears in.)
drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function)
make[2]: *** [drivers/net/ucc_geth.o] Error 1
Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com>
---
--- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500
+++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 22:28:13.000000000 -0500
@@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g
static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match)
{
+ struct device_node *mdio;
+ const phandle *ph;
struct device *device = &ofdev->dev;
struct device_node *np = ofdev->node;
struct net_device *dev = NULL;
---
Regards--
Subrata
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] 2009-06-11 3:37 [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] Subrata Modak @ 2009-06-15 6:51 ` Subrata Modak 2009-06-17 12:51 ` Subrata Modak 0 siblings, 1 reply; 9+ messages in thread From: Subrata Modak @ 2009-06-15 6:51 UTC (permalink / raw) To: Tony Breeds, netdev, michael, Li Yang, Nathan Lynch Cc: Stephen Rothwell, Sachin P Sant, Linux-Next, Linux-Kernel, Balbir Singh, Linuxppc-dev Hi Li/Nathan, On Thu, 2009-06-11 at 09:07 +0530, Subrata Modak wrote: > Hi Nathan, > > >On Wed, 2009-06-10 at 21:28 -0500, Nathan Lynch wrote: > >Subrata Modak <subrata@linux.vnet.ibm.com> writes: > > > > > On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote: > > >> Hi Subrata, > > >> > > >> On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak <subrata@linux.vnet.ibm.com> wrote: > > >> > > > >> > /* Find the TBI PHY. If it's not there, we don't support SGMII */ > > >> > - ph = of_get_property(np, "tbi-handle", NULL); > > >> > + ph = (phandle *)of_get_property(np, "tbi-handle", NULL); > > >> > > >> You don't need this cast because of_get_property() returns "void *". > > > > > > Stephen, > > > > > > True. But without this gcc complains: > > > > > > CC [M] drivers/net/ucc_geth.o > > > drivers/net/ucc_geth.c: In function b\x18ucc_geth_probeb\x19: > > > drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers > > > from pointer target type > > > > ph should be declared const phandle *. Look at other uses of > > of_get_property. > > > > Ok fine. Here is a revised patch again. > > Subject: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] > Reference(s): > http://lkml.org/lkml/2009/6/4/241, > http://lkml.org/lkml/2009/6/10/338, > > Fix the following build error: > > drivers/net/ucc_geth.c: In function bucc_geth_probeb: > drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) > drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once > drivers/net/ucc_geth.c:3822: error: for each function it appears in.) > drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) > make[2]: *** [drivers/net/ucc_geth.o] Error 1 > > Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com> > --- Is there anything else to be done in this patch. If this is OK, can this be applied. I am not sure, but, i find Li Yang as the maintainer for this in linux*/MAINTAINERS file. Kindly let me know if this patch needs to be revisited for some other issue(s). Regards-- Subrata > > --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500 > +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 22:28:13.000000000 -0500 > @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g > > static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) > { > + struct device_node *mdio; > + const phandle *ph; > struct device *device = &ofdev->dev; > struct device_node *np = ofdev->node; > struct net_device *dev = NULL; > > --- > Regards-- > Subrata > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] 2009-06-15 6:51 ` Subrata Modak @ 2009-06-17 12:51 ` Subrata Modak 2009-06-17 13:07 ` Kumar Gala 0 siblings, 1 reply; 9+ messages in thread From: Subrata Modak @ 2009-06-17 12:51 UTC (permalink / raw) To: netdev, Li Yang Cc: Nathan Lynch, Stephen Rothwell, Sachin P Sant, Linux-Next, Linux-Kernel, Balbir Singh, Linuxppc-dev, Tony Breeds, michael On Mon, 2009-06-15 at 12:22 +0530, Subrata Modak wrote: > Hi Li/Nathan, > > On Thu, 2009-06-11 at 09:07 +0530, Subrata Modak wrote: > > Hi Nathan, > > > > >On Wed, 2009-06-10 at 21:28 -0500, Nathan Lynch wrote: > > >Subrata Modak <subrata@linux.vnet.ibm.com> writes: > > > > > > > On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote: > > > >> Hi Subrata, > > > >> > > > >> On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak <subrata@linux.vnet.ibm.com> wrote: > > > >> > > > > >> > /* Find the TBI PHY. If it's not there, we don't support SGMII */ > > > >> > - ph = of_get_property(np, "tbi-handle", NULL); > > > >> > + ph = (phandle *)of_get_property(np, "tbi-handle", NULL); > > > >> > > > >> You don't need this cast because of_get_property() returns "void *". > > > > > > > > Stephen, > > > > > > > > True. But without this gcc complains: > > > > > > > > CC [M] drivers/net/ucc_geth.o > > > > drivers/net/ucc_geth.c: In function b\x18ucc_geth_probeb\x19: > > > > drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers > > > > from pointer target type > > > > > > ph should be declared const phandle *. Look at other uses of > > > of_get_property. > > > > > > > Ok fine. Here is a revised patch again. > > > > Subject: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] > > Reference(s): > > http://lkml.org/lkml/2009/6/4/241, > > http://lkml.org/lkml/2009/6/10/338, > > > > Fix the following build error: > > > > drivers/net/ucc_geth.c: In function bucc_geth_probeb: > > drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) > > drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once > > drivers/net/ucc_geth.c:3822: error: for each function it appears in.) > > drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) > > make[2]: *** [drivers/net/ucc_geth.o] Error 1 > > > > Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com> > > --- > > Is there anything else to be done in this patch. If this is OK, can this > be applied. I am not sure, but, i find Li Yang as the maintainer for > this in linux*/MAINTAINERS file. Kindly let me know if this patch needs > to be revisited for some other issue(s). Li, Any thoughts on this patch ? Regards-- Subrata > > Regards-- > Subrata > > > > > --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500 > > +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 22:28:13.000000000 -0500 > > @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g > > > > static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) > > { > > + struct device_node *mdio; > > + const phandle *ph; > > struct device *device = &ofdev->dev; > > struct device_node *np = ofdev->node; > > struct net_device *dev = NULL; > > > > --- > > Regards-- > > Subrata > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] 2009-06-17 12:51 ` Subrata Modak @ 2009-06-17 13:07 ` Kumar Gala 2009-06-17 13:23 ` Stephen Rothwell 0 siblings, 1 reply; 9+ messages in thread From: Kumar Gala @ 2009-06-17 13:07 UTC (permalink / raw) To: subrata Cc: netdev, Li Yang, Nathan Lynch, Stephen Rothwell, Sachin P Sant, Linux-Next, Linux-Kernel, Balbir Singh, Linuxppc-dev, Tony Breeds, michael On Jun 17, 2009, at 7:51 AM, Subrata Modak wrote: > On Mon, 2009-06-15 at 12:22 +0530, Subrata Modak wrote: >> Hi Li/Nathan, >> >> On Thu, 2009-06-11 at 09:07 +0530, Subrata Modak wrote: >>> Hi Nathan, >>> >>>> On Wed, 2009-06-10 at 21:28 -0500, Nathan Lynch wrote: >>>> Subrata Modak <subrata@linux.vnet.ibm.com> writes: >>>> >>>>> On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote: >>>>>> Hi Subrata, >>>>>> >>>>>> On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak <subrata@linux.vnet.ibm.com >>>>>> > wrote: >>>>>>> >>>>>>> /* Find the TBI PHY. If it's not there, we don't support >>>>>>> SGMII */ >>>>>>> - ph = of_get_property(np, "tbi-handle", NULL); >>>>>>> + ph = (phandle *)of_get_property(np, "tbi-handle", NULL); >>>>>> >>>>>> You don't need this cast because of_get_property() returns >>>>>> "void *". >>>>> >>>>> Stephen, >>>>> >>>>> True. But without this gcc complains: >>>>> >>>>> CC [M] drivers/net/ucc_geth.o >>>>> drivers/net/ucc_geth.c: In function b\x18ucc_geth_probeb\x19: >>>>> drivers/net/ucc_geth.c:3824: warning: assignment discards >>>>> qualifiers >>>>> from pointer target type >>>> >>>> ph should be declared const phandle *. Look at other uses of >>>> of_get_property. >>>> >>> >>> Ok fine. Here is a revised patch again. >>> >>> Subject: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 >>> randconfig [drivers/net/ucc_geth.o] >>> Reference(s): >>> http://lkml.org/lkml/2009/6/4/241, >>> http://lkml.org/lkml/2009/6/10/338, >>> >>> Fix the following build error: >>> >>> drivers/net/ucc_geth.c: In function bucc_geth_probeb: >>> drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in >>> this function) >>> drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is >>> reported only once >>> drivers/net/ucc_geth.c:3822: error: for each function it appears >>> in.) >>> drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use >>> in this function) >>> make[2]: *** [drivers/net/ucc_geth.o] Error 1 >>> >>> Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com> >>> --- >> >> Is there anything else to be done in this patch. If this is OK, can >> this >> be applied. I am not sure, but, i find Li Yang as the maintainer for >> this in linux*/MAINTAINERS file. Kindly let me know if this patch >> needs >> to be revisited for some other issue(s). > > Li, > > Any thoughts on this patch ? > > > Regards-- > Subrata > >> >> Regards-- >> Subrata >> >>> >>> --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 >>> 11:58:39.000000000 -0500 >>> +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 >>> 22:28:13.000000000 -0500 >>> @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g >>> >>> static int ucc_geth_probe(struct of_device* ofdev, const struct >>> of_device_id *match) >>> { >>> + struct device_node *mdio; >>> + const phandle *ph; >>> struct device *device = &ofdev->dev; >>> struct device_node *np = ofdev->node; >>> struct net_device *dev = NULL; >>> >>> --- >>> Regards-- >>> Subrata >>> I'm confused by the proposed fix as we already have *mdio & *ph defined in this function: static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) { struct device *device = &ofdev->dev; struct device_node *np = ofdev->node; struct device_node *mdio; struct net_device *dev = NULL; struct ucc_geth_private *ugeth = NULL; struct ucc_geth_info *ug_info; struct resource res; struct device_node *phy; int err, ucc_num, max_speed = 0; const phandle *ph; const u32 *fixed_link; const unsigned int *prop; const char *sprop; const void *mac_addr; ... - k ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] 2009-06-17 13:07 ` Kumar Gala @ 2009-06-17 13:23 ` Stephen Rothwell 2009-06-17 13:34 ` Stephen Rothwell 0 siblings, 1 reply; 9+ messages in thread From: Stephen Rothwell @ 2009-06-17 13:23 UTC (permalink / raw) To: Kumar Gala Cc: subrata, netdev, Li Yang, Nathan Lynch, Sachin P Sant, Linux-Next, Linux-Kernel, Balbir Singh, Linuxppc-dev, Tony Breeds, michael [-- Attachment #1: Type: text/plain, Size: 412 bytes --] Hi Kumar, On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala <galak@kernel.crashing.org> wrote: > > > I'm confused by the proposed fix as we already have *mdio & *ph > defined in this function: Which tree are you looking at? Linus' tree, and linux-next, do not have those local variables ... -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] 2009-06-17 13:23 ` Stephen Rothwell @ 2009-06-17 13:34 ` Stephen Rothwell 2009-06-17 13:49 ` Kumar Gala 2009-06-17 17:29 ` Grant Likely 0 siblings, 2 replies; 9+ messages in thread From: Stephen Rothwell @ 2009-06-17 13:34 UTC (permalink / raw) To: Kumar Gala Cc: subrata, netdev, Li Yang, Nathan Lynch, Sachin P Sant, Linux-Next, Linux-Kernel, Balbir Singh, Linuxppc-dev, Tony Breeds, michael, Haiying Wang, David S. Miller, Grant Likely On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Hi Kumar, > > On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala <galak@kernel.crashing.org> wrote: > > > > > > I'm confused by the proposed fix as we already have *mdio & *ph > > defined in this function: > > Which tree are you looking at? Linus' tree, and linux-next, do not have > those local variables ... Hmmm, commit 0b9da337dca972e7a4144e298ec3adb8f244d4a4 ("net: Rework ucc_geth driver to use of_mdio infrastructure") removed the locals along with their usages, then commit 047584ce94108012288554a5f84585d792cc7f8f ("net/ucc_geth: Add SGMII support for UEC GETH driver") added more uses without adding the variables back. Here is the patch again: From: Subrata Modak <subrata@linux.vnet.ibm.com> Subject: [PATCH] Fix build error in ucc_geth.c Fix the following build error: drivers/net/ucc_geth.c: In function bucc_geth_probeb: drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once drivers/net/ucc_geth.c:3822: error: for each function it appears in.) drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) make[2]: *** [drivers/net/ucc_geth.o] Error 1 Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com> --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500 +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 22:28:13.000000000 -0500 @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) { + struct device_node *mdio; + const phandle *ph; struct device *device = &ofdev->dev; struct device_node *np = ofdev->node; struct net_device *dev = NULL; -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] 2009-06-17 13:34 ` Stephen Rothwell @ 2009-06-17 13:49 ` Kumar Gala 2009-06-17 17:29 ` Grant Likely 1 sibling, 0 replies; 9+ messages in thread From: Kumar Gala @ 2009-06-17 13:49 UTC (permalink / raw) To: Stephen Rothwell Cc: Sachin P Sant, netdev, Linux-Kernel, Linuxppc-dev, Linux-Next, Nathan Lynch, Haiying Wang, Li Yang, subrata, David S. Miller, Balbir Singh On Jun 17, 2009, at 8:34 AM, Stephen Rothwell wrote: > On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell <sfr@canb.auug.org.au > > wrote: >> >> Hi Kumar, >> >> On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala <galak@kernel.crashing.org >> > wrote: >>> >>> >>> I'm confused by the proposed fix as we already have *mdio & *ph >>> defined in this function: >> >> Which tree are you looking at? Linus' tree, and linux-next, do not >> have >> those local variables ... > > Hmmm, commit 0b9da337dca972e7a4144e298ec3adb8f244d4a4 ("net: Rework > ucc_geth driver to use of_mdio infrastructure") removed the locals > along > with their usages, then commit > 047584ce94108012288554a5f84585d792cc7f8f > ("net/ucc_geth: Add SGMII support for UEC GETH driver") added more > uses > without adding the variables back. > > Here is the patch again: > > From: Subrata Modak <subrata@linux.vnet.ibm.com> > Subject: [PATCH] Fix build error in ucc_geth.c > > Fix the following build error: > > drivers/net/ucc_geth.c: In function bucc_geth_probeb: > drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in > this function) > drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is > reported only once > drivers/net/ucc_geth.c:3822: error: for each function it appears in.) > drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in > this function) > make[2]: *** [drivers/net/ucc_geth.o] Error 1 > > Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com> > > --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 > 11:58:39.000000000 -0500 > +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 > 22:28:13.000000000 -0500 > @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g > > static int ucc_geth_probe(struct of_device* ofdev, const struct > of_device_id *match) > { > + struct device_node *mdio; > + const phandle *ph; > struct device *device = &ofdev->dev; > struct device_node *np = ofdev->node; > struct net_device *dev = NULL; ah... was looking at powerpc next which hasn't pulled in linus's latest tree w/netdev updates. - k ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] 2009-06-17 13:34 ` Stephen Rothwell 2009-06-17 13:49 ` Kumar Gala @ 2009-06-17 17:29 ` Grant Likely 2009-06-17 20:37 ` Grant Likely 1 sibling, 1 reply; 9+ messages in thread From: Grant Likely @ 2009-06-17 17:29 UTC (permalink / raw) To: Stephen Rothwell Cc: Kumar Gala, subrata, netdev, Li Yang, Nathan Lynch, Sachin P Sant, Linux-Next, Linux-Kernel, Balbir Singh, Linuxppc-dev, Tony Breeds, michael, Haiying Wang, David S. Miller On Wed, Jun 17, 2009 at 7:34 AM, Stephen Rothwell<sfr@canb.auug.org.au> wrote: > On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> >> Hi Kumar, >> >> On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala <galak@kernel.crashing.org> wrote: >> > >> > >> > I'm confused by the proposed fix as we already have *mdio & *ph >> > defined in this function: >> >> Which tree are you looking at? Linus' tree, and linux-next, do not have >> those local variables ... > > Hmmm, commit 0b9da337dca972e7a4144e298ec3adb8f244d4a4 ("net: Rework > ucc_geth driver to use of_mdio infrastructure") removed the locals along > with their usages, then commit 047584ce94108012288554a5f84585d792cc7f8f > ("net/ucc_geth: Add SGMII support for UEC GETH driver") added more uses > without adding the variables back. > > Here is the patch again: > > From: Subrata Modak <subrata@linux.vnet.ibm.com> > Subject: [PATCH] Fix build error in ucc_geth.c > > Fix the following build error: > > drivers/net/ucc_geth.c: In function bucc_geth_probeb: > drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) > drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once > drivers/net/ucc_geth.c:3822: error: for each function it appears in.) > drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) > make[2]: *** [drivers/net/ucc_geth.o] Error 1 > > Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com> > > --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500 > +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 22:28:13.000000000 -0500 > @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g > > static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) > { > + struct device_node *mdio; > + const phandle *ph; > struct device *device = &ofdev->dev; > struct device_node *np = ofdev->node; > struct net_device *dev = NULL; Ah, this might not be the right fix then. I'll look. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] 2009-06-17 17:29 ` Grant Likely @ 2009-06-17 20:37 ` Grant Likely 0 siblings, 0 replies; 9+ messages in thread From: Grant Likely @ 2009-06-17 20:37 UTC (permalink / raw) To: Stephen Rothwell Cc: Kumar Gala, subrata, netdev, Li Yang, Nathan Lynch, Sachin P Sant, Linux-Next, Linux-Kernel, Balbir Singh, Linuxppc-dev, Tony Breeds, michael, Haiying Wang, David S. Miller On Wed, Jun 17, 2009 at 11:29 AM, Grant Likely<grant.likely@secretlab.ca> wrote: > On Wed, Jun 17, 2009 at 7:34 AM, Stephen Rothwell<sfr@canb.auug.org.au> wrote: >> On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >>> >>> Hi Kumar, >>> >>> On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala <galak@kernel.crashing.org> wrote: >>> > >>> > >>> > I'm confused by the proposed fix as we already have *mdio & *ph >>> > defined in this function: >>> >>> Which tree are you looking at? Linus' tree, and linux-next, do not have >>> those local variables ... >> >> Hmmm, commit 0b9da337dca972e7a4144e298ec3adb8f244d4a4 ("net: Rework >> ucc_geth driver to use of_mdio infrastructure") removed the locals along >> with their usages, then commit 047584ce94108012288554a5f84585d792cc7f8f >> ("net/ucc_geth: Add SGMII support for UEC GETH driver") added more uses >> without adding the variables back. >> >> Here is the patch again: >> >> From: Subrata Modak <subrata@linux.vnet.ibm.com> >> Subject: [PATCH] Fix build error in ucc_geth.c >> >> Fix the following build error: >> >> drivers/net/ucc_geth.c: In function bucc_geth_probeb: >> drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) >> drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once >> drivers/net/ucc_geth.c:3822: error: for each function it appears in.) >> drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) >> make[2]: *** [drivers/net/ucc_geth.o] Error 1 >> >> Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com> >> >> --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500 >> +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 22:28:13.000000000 -0500 >> @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g >> >> static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) >> { >> + struct device_node *mdio; >> + const phandle *ph; >> struct device *device = &ofdev->dev; >> struct device_node *np = ofdev->node; >> struct net_device *dev = NULL; > > Ah, this might not be the right fix then. I'll look. Yeah, this is not the right fix. The SGMII change doesn't mesh well with the of_mdio changes and needed some rewriting. I'm about to post a patch (compile tested only) which should make things happy. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-06-17 20:37 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-06-11 3:37 [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] Subrata Modak 2009-06-15 6:51 ` Subrata Modak 2009-06-17 12:51 ` Subrata Modak 2009-06-17 13:07 ` Kumar Gala 2009-06-17 13:23 ` Stephen Rothwell 2009-06-17 13:34 ` Stephen Rothwell 2009-06-17 13:49 ` Kumar Gala 2009-06-17 17:29 ` Grant Likely 2009-06-17 20:37 ` Grant Likely
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).