From: Ben Hutchings <bhutchings@solarflare.com>
To: Peter Chacko <peterchacko35@gmail.com>
Cc: David Miller <davem@davemloft.net>,
rick.jones2@hp.com, radhamohan_ch@yahoo.com,
netdev@vger.kernel.org
Subject: Re: can we reuse an skb
Date: Sat, 20 Jun 2009 12:51:27 +0100 [thread overview]
Message-ID: <1245498687.12125.24.camel@deadeye> (raw)
In-Reply-To: <1f808b4a0906192054k6182ac2fh1618f0e630033518@mail.gmail.com>
On Sat, 2009-06-20 at 09:24 +0530, Peter Chacko wrote:
> But if a network application is holding on to a NIC-drive level pooled
> buffers, we also have architectural issues in violating layered
> software design. Application plays at a stateful protocol level, while
> driver should be stateless and flow-unaware.
Meanwhile, in the real world, we want to avoid copying data, so an skb
doesn't belong to any specific protocol layer.
> Another thought in the lines of radha's original idea:
>
> Assume that we have n-cores capable of processing packet at the same
> time. if we trade off memory for computing, why don't we pre-allocate
> "n" dedicated skb buffers regardless of the size of each packet, but
> just as big as the size of the MTU itself.(forget JUMBO packet for
> now).
MTU is interface-specific, and the MTU tells us whether jumbos are
allowed or not.
Anyway, where is this pre-allocation to be done?
> ( today, dev_alloc_skb() allocate based on the packet len, which
> is memory usage optimized.).
[...]
skbs for received packets are normally allocated in advance anyway,
which means they are already MTU-sized. However, LRO or GRO can make it
worthwhile to defer skb allocation.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-06-20 11:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 6:46 can we reuse an skb Radha Mohan
2009-06-19 6:51 ` jon_zhou
2009-06-19 7:10 ` Radha Mohan
2009-06-19 7:21 ` Peter Chacko
2009-06-19 10:37 ` Saikiran Madugula
2009-06-19 18:41 ` Neil Horman
2009-06-19 16:56 ` Rick Jones
2009-06-19 23:29 ` David Miller
2009-06-20 3:54 ` Peter Chacko
2009-06-20 8:00 ` Evgeniy Polyakov
2009-06-20 11:51 ` Ben Hutchings [this message]
2009-06-21 5:41 ` Peter Chacko
2009-06-21 5:49 ` David Miller
2009-06-21 11:46 ` [RFD] Pluggable code design (was: can we reuse an skb) Al Boldi
-- strict thread matches above, loose matches on Subject: below --
2009-06-19 10:11 can we reuse an skb Nicholas Van Orton
2009-06-22 13:34 ` Philby John
2009-06-22 13:56 ` Peter Chacko
2009-06-22 14:33 ` Philby John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245498687.12125.24.camel@deadeye \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peterchacko35@gmail.com \
--cc=radhamohan_ch@yahoo.com \
--cc=rick.jones2@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).