From: Jesper Dangaard Brouer <hawk@comx.dk>
To: Christian Kujau <lists@nerdbynature.de>
Cc: Jesper Dangaard Brouer <hawk@diku.dk>,
David Miller <davem@davemloft.net>,
paulmck@linux.vnet.ibm.com, netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>,
yoshfuji@linux-ipv6.org, linux-nfs@vger.kernel.org,
linux-ext4@vger.kernel.org, catalin.marinas@gmail.com
Subject: Re: [PATCH 07/10] decnet: Use rcu_barrier() on module unload.
Date: Sat, 27 Jun 2009 09:35:04 +0200 [thread overview]
Message-ID: <1246088104.29340.5.camel@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.01.0906262010091.6439@bogon>
On Fri, 2009-06-26 at 20:15 -0700, Christian Kujau wrote:
> On Fri, 26 Jun 2009, Jesper Dangaard Brouer wrote:
> > I'll resubmit the patches to you and netdev, to limit the spam effect...
>
> Out of curiosity: why was linux-ext4 Cc'ed on these rcu_barrier patches
> (but not other fs-lists but linux-nfs)? I did not see any ../fs/ext4/
> changes.
There was a ../fs/ext4/ change in patch [01/10].
Titled: "ext4: Use rcu_barrier() on module unload"
git show --stat d6a4ea73b7e8779607dd48735d9a9c521c890857
commit d6a4ea73b7e8779607dd48735d9a9c521c890857
Author: Jesper Dangaard Brouer <hawk@comx.dk>
Date: Tue Jun 23 15:40:54 2009 +0200
ext4: Use rcu_barrier() on module unload.
The ext4 module uses rcu_call() thus it should use rcu_barrier()on
module unload.
The kmem cache ext4_pspace_cachep is sometimes free'ed using
call_rcu() callbacks. Thus, we must wait for completion of call_rcu()
before doing kmem_cache_destroy().
I have difficult determining if no new call_rcu() callbacks can be envoked.
Would the maintainer please verify this?
Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
fs/ext4/mballoc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
--
Med venlig hilsen / Best regards
Jesper Brouer
ComX Networks A/S
Linux Network developer
Cand. Scient Datalog / MSc.
Author of http://adsl-optimizer.dk
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2009-06-27 7:35 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 15:03 [PATCH 00/10] We must use rcu_barrier() on module unload Jesper Dangaard Brouer
2009-06-23 15:03 ` [PATCH 01/10] ext4: Use " Jesper Dangaard Brouer
2009-07-06 2:31 ` Theodore Tso
2009-06-23 15:04 ` [PATCH 02/10] bridge: Use rcu_barrier() instead of syncronize_net() on unload Jesper Dangaard Brouer
2009-06-23 15:04 ` [PATCH 03/10] mac80211: Use rcu_barrier() " Jesper Dangaard Brouer
2009-06-23 15:15 ` Johannes Berg
[not found] ` <1245770155.21314.38.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-24 10:06 ` Jesper Dangaard Brouer
2009-06-24 10:21 ` Johannes Berg
[not found] ` <1245838862.21314.48.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-24 11:32 ` Jesper Dangaard Brouer
2009-06-24 11:39 ` Johannes Berg
2009-06-23 15:04 ` [PATCH 04/10] sunrpc: " Jesper Dangaard Brouer
2009-06-23 16:59 ` Trond Myklebust
2009-06-23 15:04 ` [PATCH 05/10] nfs: Use rcu_barrier() on module unload Jesper Dangaard Brouer
2009-06-23 15:04 ` [PATCH 06/10] ipv6: " Jesper Dangaard Brouer
2009-06-23 15:04 ` [PATCH 07/10] decnet: " Jesper Dangaard Brouer
2009-06-24 6:23 ` Chrissie Caulfield
2009-06-24 11:44 ` Jesper Dangaard Brouer
[not found] ` <1245843884.6695.54.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-06-24 12:09 ` Jesper Dangaard Brouer
[not found] ` <1245845367.24921.3.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-06-24 13:50 ` Chrissie Caulfield
[not found] ` <5A680E0A-EFEB-44EA-9F06-F338E6CBD6D1-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2009-06-25 11:52 ` Jesper Dangaard Brouer
[not found] ` <1245930729.24921.67.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-06-25 23:10 ` David Miller
[not found] ` <20090625.161046.19938291.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-06-26 19:18 ` Jesper Dangaard Brouer
2009-06-27 3:15 ` Christian Kujau
2009-06-27 7:35 ` Jesper Dangaard Brouer [this message]
2009-06-23 15:04 ` [PATCH 08/10] edac_core: Uses call_rcu() and its own wait_for_completion scheme Jesper Dangaard Brouer
2009-06-23 15:04 ` [PATCH 09/10] cfq-iosched: Uses its own open-coded rcu_barrier Jesper Dangaard Brouer
2009-06-24 6:42 ` Jens Axboe
[not found] ` <20090624064236.GE31415-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2009-06-24 14:05 ` Paul E. McKenney
2009-06-23 15:04 ` [PATCH 10/10] nf_conntrack: Use rcu_barrier() Jesper Dangaard Brouer
2009-06-23 16:23 ` Patrick McHardy
2009-06-24 9:02 ` Jesper Dangaard Brouer
2009-06-24 9:40 ` [PATCH v2 10/10] nf_conntrack: Use rcu_barrier() and fix kmem_cache_create flags Jesper Dangaard Brouer
2009-06-24 13:58 ` Patrick McHardy
2009-06-25 9:29 ` Jesper Dangaard Brouer
2009-06-25 10:02 ` [PATCH v3 10/10] nf_conntrack: Use rcu_barrier() Jesper Dangaard Brouer
2009-06-25 14:33 ` Patrick McHardy
2009-06-25 13:59 ` [PATCH v2 10/10] nf_conntrack: Use rcu_barrier() and fix kmem_cache_create flags Patrick McHardy
2009-06-25 19:32 ` Paul E. McKenney
2009-06-24 1:44 ` [PATCH 00/10] We must use rcu_barrier() on module unload Paul E. McKenney
2009-06-24 7:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246088104.29340.5.camel@localhost.localdomain \
--to=hawk@comx.dk \
--cc=catalin.marinas@gmail.com \
--cc=davem@davemloft.net \
--cc=hawk@diku.dk \
--cc=kaber@trash.net \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).