netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH] bridge: make bridge-nf-call-*tables default configurable
Date: Wed, 01 Jul 2009 11:45:58 +0100	[thread overview]
Message-ID: <1246445158.598.30.camel@blaa> (raw)
In-Reply-To: <20090630.201630.134200035.davem@davemloft.net>

On Tue, 2009-06-30 at 20:16 -0700, David Miller wrote:
> From: Mark McLoughlin <markmc@redhat.com>
> Date: Tue, 30 Jun 2009 17:27:47 +0100
> 
> > For these reasons, it makes sense to allow distributions to disable
> > netfilter on the bridge by default and require those specialized users
> > to enable it explicitly via sysctl.
> 
> I heard that distributions ship some file, what's it called...
> something like /etc/sysctl.conf :-)
> 
> Really, if someone thinkgs the default stinks and dists don't like it
> for their users, they can use sysctl.conf to set it how they please.

If upstream agrees the default stinks, then upstream could start making
moves towards rectifying it :-)

I like Patrick's idea of adding it to feature-removal-schedule

> Notwithstanding that changing this default can break working
> setups and scripts.  Yes they can "change", but they were just
> (rightly) using the kernel as it came to them.

Yep, that's a valid concern.

Weighing up the impact on the small number of people who use it versus
the ongoing impact on everyone else, I think it's best to make the
change.

Cheers,
Mark.


  reply	other threads:[~2009-07-01 10:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1246379267.3749.42.camel@blaa>
2009-06-30 17:00 ` [PATCH] bridge: make bridge-nf-call-*tables default configurable Herbert Xu
2009-06-30 19:06   ` David Miller
2009-06-30 20:16     ` Jan Engelhardt
2009-06-30 20:57       ` Mark Smith
2009-06-30 21:30         ` Jan Engelhardt
2009-07-01  1:48         ` Herbert Xu
2009-07-01  1:15       ` Herbert Xu
2009-07-01  3:50         ` Jan Engelhardt
2009-07-01  4:10           ` Herbert Xu
2009-07-01  4:14           ` Ben Greear
2009-07-01  9:01         ` Patrick McHardy
2009-07-01  8:57   ` Patrick McHardy
2009-07-01  9:07     ` Herbert Xu
2009-07-01  9:21       ` Patrick McHardy
2009-07-01 16:33         ` Herbert Xu
2009-07-01 17:01           ` Patrick McHardy
2009-07-01  3:16 ` David Miller
2009-07-01 10:45   ` Mark McLoughlin [this message]
2009-07-01 10:51     ` Patrick McHardy
2009-07-01 16:02       ` David Miller
2009-07-01 16:05         ` Patrick McHardy
2009-07-01 16:08           ` David Miller
2009-07-01 21:18           ` Mark Smith
2009-07-01 16:02     ` David Miller
2009-07-01 16:26       ` Herbert Xu
2009-07-01  8:56 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246445158.598.30.camel@blaa \
    --to=markmc@redhat.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).