From: Ben Hutchings <bhutchings@solarflare.com>
To: Sarveshwar Bandi <sarveshwarb@serverengines.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] be2net: Implementation of request_firmware interface.
Date: Thu, 02 Jul 2009 21:33:28 +0100 [thread overview]
Message-ID: <1246566808.9821.2.camel@deadeye> (raw)
In-Reply-To: <20090702111820.GA21085@serverengines.com>
On Thu, 2009-07-02 at 16:48 +0530, Sarveshwar Bandi wrote:
> Please review and apply patch to net-next tree. Patch implements the
> request_firmware interface.
[...]
> + /* fw ver on board matches */
> + if (!strncmp(fhdr->sign + strlen(FW_FILE_HDR_SIGN), fw_ver,
> + FW_VER_LEN))
> + goto fw_exit;
> +
> + dev_info(&adapter->pdev->dev,
> + "Flashing firmware file %s\n", fw_file);
[...]
request_firmware() is really intended for loading non-persistent
"firmware" that must be loaded into the device's RAM after power-on
reset. It is not expected and should not be necessary that drivers
automatically update firmware in flash memory. I also understand that
some OEMs specifically forbid their suppliers to do this automatically
in drivers.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-07-02 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 11:18 [PATCH] be2net: Implementation of request_firmware interface Sarveshwar Bandi
2009-07-02 20:33 ` Ben Hutchings [this message]
2009-07-05 12:16 ` Sarveshwar Bandi
2009-07-05 14:20 ` Ben Hutchings
2009-08-07 9:20 ` Ram Pai
2009-08-07 13:20 ` Ben Hutchings
2009-08-11 16:55 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246566808.9821.2.camel@deadeye \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sarveshwarb@serverengines.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).