From: Matt Mackall <mpm@selenic.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Anton Vorontsov <avorontsov@ru.mvista.com>,
Andrew Morton <akpm@linux-foundation.org>,
oleg@redhat.com, mingo@elte.hu, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] netpoll: Fix carrier detection for drivers that are using phylib
Date: Thu, 09 Jul 2009 07:56:42 -0500 [thread overview]
Message-ID: <1247144202.21295.869.camel@calx> (raw)
In-Reply-To: <1247126210.9777.317.camel@twins>
On Thu, 2009-07-09 at 09:56 +0200, Peter Zijlstra wrote:
> On Wed, 2009-07-08 at 17:01 -0700, Linus Torvalds wrote:
> > Looking at the people looking at SYSTEM_RUNNING, I do note some odd cases.
> > Why the heck does kernel/perf_counter.c do it, for example?
>
> Ah, those are the swcounter and other probe entry points. I've had
> several cases where we called into the perf counter code from those
> points before it was initialized, getting in kernel segfaults due to
> dereferencing uninitialized data etc..
>
> I could keep a variable that tracked the perf_counter_init() state, and
> use that instead if you prefer?
Looks like that'd be more accurate. Linus's proposed patch might break
your current assumptions.
--
http://selenic.com : development and support for Mercurial and Linux
next prev parent reply other threads:[~2009-07-09 12:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090707235812.GA12824@oksana.dev.rtsoft.ru>
[not found] ` <20090708005000.GA12380@redhat.com>
[not found] ` <1247034263.9777.24.camel@twins>
[not found] ` <alpine.LFD.2.01.0907080907210.3210@localhost.localdomain>
[not found] ` <20090708141024.f8b581c5.akpm@linux-foundation.org>
[not found] ` <20090708213331.GA9346@oksana.dev.rtsoft.ru>
2009-07-08 21:47 ` [PATCH/RFC] sched: Remove SYSTEM_RUNNING checks from cond_resched*() Andrew Morton
2009-07-08 22:20 ` [PATCH] netpoll: Fix carrier detection for drivers that are using phylib Anton Vorontsov
2009-07-09 0:01 ` Linus Torvalds
2009-07-09 3:08 ` David Miller
2009-07-09 7:56 ` Peter Zijlstra
2009-07-09 12:56 ` Matt Mackall [this message]
2009-07-09 13:26 ` Matt Mackall
2009-07-09 13:46 ` Peter Zijlstra
2009-07-09 14:18 ` Matt Mackall
2009-07-09 14:31 ` Peter Zijlstra
2009-07-09 14:43 ` Matt Mackall
2009-07-09 14:51 ` Peter Zijlstra
2009-07-09 15:06 ` Matt Mackall
2009-07-09 17:29 ` Linus Torvalds
2009-07-09 12:52 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247144202.21295.869.camel@calx \
--to=mpm@selenic.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).