From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [patch 1/3] net: serialize hrtimer callback in sched_cbq Date: Wed, 22 Jul 2009 08:29:44 +0200 Message-ID: <1248244184.27058.992.camel@twins> References: <1247588890.7500.186.camel@twins> <1247832892.15751.35.camel@twins> <20090721.201855.32703627.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: torvalds@linux-foundation.org, tglx@linutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kaber@trash.net To: David Miller Return-path: In-Reply-To: <20090721.201855.32703627.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 2009-07-21 at 20:18 -0700, David Miller wrote: > From: Peter Zijlstra > Date: Fri, 17 Jul 2009 14:14:52 +0200 > > > On Tue, 2009-07-14 at 09:42 -0700, Linus Torvalds wrote: > >> > >> On Tue, 14 Jul 2009, Peter Zijlstra wrote: > >> > > >> > Linus really hated the softirq mode, which is what prompted me to change > >> > that. > >> > > >> > Now, it might be he only hated the particular interface and the > >> > resulting code, but I think to remember he simply thought the whole > >> > thing daft. > >> > >> Yes. And I hated the bugs it had. > >> > >> Don't make something as core as timers any more complicated. Don't take > >> locks in timers and then complain about deadlocks. If your locking is > >> broken, don't make the core timers be idiotically broken. > >> > >> Because it was. The code was a total mess to follow, and had bugs. > > > > How would something like the below work for people? > > I like it, but like Linus said it probably belongs in > kernel/softirq.c Right, I meant to rework it, but stuff kept preempting me. I'll try and get around to it today :-)