From: Robert Love <robert.w.love@intel.com>
To: davem@davemloft.net, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
gospo@redhat.com, devel@open-fcoe.org
Subject: Re: [Open-FCoE] [net-next-2.6 PATCH 5/5] fcoe: Use NETIF_F_FCOE_MTU flag to set up max frame size (lport->mfs)
Date: Thu, 23 Jul 2009 11:27:28 -0700 [thread overview]
Message-ID: <1248373648.23392.24.camel@fritz> (raw)
In-Reply-To: <20090722232956.26937.24429.stgit@localhost.localdomain>
On Wed, 2009-07-22 at 16:29 -0700, Jeff Kirsher wrote:
> From: Yi Zou <yi.zou@intel.com>
>
> Add a define of FCOE_MTU as 2158 bytes and use FCOE_MTU when the LLD is found
> to support NETIF_F_FCOE_MTU. The lport->mfs is then calculated out of the
> 2158 FCOE_MTU. Otherwise, we stick with the netdev->mtu, i.e., LAN MTU. Also,
> change the notification on NETDEV_CHANGEMTU event to bypass changing mfs when
> LAN MTU is changed if NETIF_F_FCOE_MTU is supported.
>
> Signed-off-by: Yi Zou <yi.zou@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
Hi Dave,
Please don't apply this patch to net-next. The other 4 patches in this
series should be fine without it. If this patch is applied to net-next
it means that most/all of the other fcoe features (that will go through
linux-scsi) become dependent on this patch.
I was hoping to push the other fcoe features as-is and then push this
patch through linux-scsi after the other 4 patches in this series had
been merged by you.
Thanks, //Rob
next prev parent reply other threads:[~2009-07-23 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 23:28 [net-next-2.6 PATCH 1/5] vlan: adds fcoe offload related net_device_ops and updates fcoe_ddp_xid field Jeff Kirsher
[not found] ` <20090722232759.26937.78765.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-07-22 23:28 ` [net-next-2.6 PATCH 2/5] ixgbe: updates vlan feature flags to enable FCoE offloads on vlan interface Jeff Kirsher
2009-07-22 23:29 ` [net-next-2.6 PATCH 3/5] net: Add NETIF_F_FCOE_MTU to indicate support for a different MTU for FCoE Jeff Kirsher
2009-07-22 23:29 ` [net-next-2.6 PATCH 4/5] ixgbe: Add support for NETIF_F_FCOE_MTU to 82599 devices Jeff Kirsher
2009-07-22 23:29 ` [net-next-2.6 PATCH 5/5] fcoe: Use NETIF_F_FCOE_MTU flag to set up max frame size (lport->mfs) Jeff Kirsher
2009-07-23 18:27 ` Robert Love [this message]
2009-07-23 18:40 ` [Open-FCoE] " David Miller
[not found] ` <20090723.114002.51085260.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-07-23 18:48 ` Robert Love
2009-07-26 16:44 ` David Miller
[not found] ` <20090726.094402.38463748.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-07-27 16:44 ` Zou, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248373648.23392.24.camel@fritz \
--to=robert.w.love@intel.com \
--cc=davem@davemloft.net \
--cc=devel@open-fcoe.org \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).