netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dhananjay Phadke <dhananjay@netxen.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: [PATCH NEXT 01/12] netxen: refresh firmware info after reset
Date: Sun, 26 Jul 2009 23:07:36 -0700	[thread overview]
Message-ID: <1248674867-18821-2-git-send-email-dhananjay@netxen.com> (raw)
In-Reply-To: <1248674867-18821-1-git-send-email-dhananjay@netxen.com>

o move dma mask update to netxen_start_firmware() so that
  if firmware changes across suspend (e.g. file -> flash)
  it reflects right dma mask.
o re-read firmware capabilities after firmware reset.

Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
---
 drivers/net/netxen/netxen_nic_hw.c   |    3 +++
 drivers/net/netxen/netxen_nic_init.c |    4 ----
 drivers/net/netxen/netxen_nic_main.c |    9 ++++-----
 3 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/net/netxen/netxen_nic_hw.c b/drivers/net/netxen/netxen_nic_hw.c
index b9123d4..3c614c3 100644
--- a/drivers/net/netxen/netxen_nic_hw.c
+++ b/drivers/net/netxen/netxen_nic_hw.c
@@ -2047,6 +2047,9 @@ void netxen_nic_get_firmware_info(struct netxen_adapter *adapter)
 		dev_info(&pdev->dev, "firmware running in %s mode\n",
 		adapter->ahw.cut_through ? "cut-through" : "legacy");
 	}
+
+	if (adapter->fw_version >= NETXEN_VERSION_CODE(4, 0, 222))
+		adapter->capabilities = NXRD32(adapter, CRB_FW_CAPABILITIES_1);
 }
 
 int
diff --git a/drivers/net/netxen/netxen_nic_init.c b/drivers/net/netxen/netxen_nic_init.c
index 5d3343e..847f78b 100644
--- a/drivers/net/netxen/netxen_nic_init.c
+++ b/drivers/net/netxen/netxen_nic_init.c
@@ -1083,10 +1083,6 @@ int netxen_init_firmware(struct netxen_adapter *adapter)
 	NXWR32(adapter, CRB_MPORT_MODE, MPORT_MULTI_FUNCTION_MODE);
 	NXWR32(adapter, CRB_CMDPEG_STATE, PHAN_INITIALIZE_ACK);
 
-	if (adapter->fw_version >= NETXEN_VERSION_CODE(4, 0, 222)) {
-		adapter->capabilities = NXRD32(adapter, CRB_FW_CAPABILITIES_1);
-	}
-
 	return err;
 }
 
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index 637ac8b..4c7e4c2 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -764,6 +764,10 @@ wait_init:
 		return err;
 	}
 
+	nx_update_dma_mask(adapter);
+
+	netxen_nic_get_firmware_info(adapter);
+
 	return 0;
 }
 
@@ -1071,11 +1075,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	err = netxen_start_firmware(adapter, 1);
 	if (err)
 		goto err_out_iounmap;
-
-	nx_update_dma_mask(adapter);
-
-	netxen_nic_get_firmware_info(adapter);
-
 	/*
 	 * See if the firmware gave us a virtual-physical port mapping.
 	 */
-- 
1.6.0.2


  reply	other threads:[~2009-07-27  6:07 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-27  6:07 [PATCH NEXT 0/12] netxen: driver update Dhananjay Phadke
2009-07-27  6:07 ` Dhananjay Phadke [this message]
2009-07-27 17:33   ` [PATCH NEXT 01/12] netxen: refresh firmware info after reset David Miller
2009-07-27  6:07 ` [PATCH NEXT 02/12] netxen: enable ip addr hashing Dhananjay Phadke
2009-07-27 17:33   ` David Miller
2009-07-27  6:07 ` [PATCH NEXT 03/12] netxen: configure interrupt coalesce defaults Dhananjay Phadke
2009-07-27 17:33   ` David Miller
2009-07-27  6:07 ` [PATCH NEXT 04/12] netxen: annotate dma watchdog setup Dhananjay Phadke
2009-07-27 17:33   ` David Miller
2009-07-27  6:07 ` [PATCH NEXT 05/12] netxen: refactor tso code Dhananjay Phadke
2009-07-27 17:34   ` David Miller
2009-07-27  6:07 ` [PATCH NEXT 06/12] netxen: module params for ring sizes Dhananjay Phadke
2009-07-27 17:31   ` David Miller
2009-07-27  6:07 ` [PATCH NEXT 07/12] netxen: clean up frimware version checks Dhananjay Phadke
2009-07-27 17:38   ` David Miller
2009-07-27  6:07 ` [PATCH NEXT 08/12] netxen: refactor net_device setup code Dhananjay Phadke
2009-07-27 17:38   ` David Miller
2009-07-27  6:07 ` [PATCH NEXT 09/12] netxen: fix skb alloc size for legacy firmware Dhananjay Phadke
2009-07-27 17:38   ` David Miller
2009-07-27  6:07 ` [PATCH NEXT 10/12] netxen: add vlan tx acceleration support Dhananjay Phadke
2009-07-27 17:38   ` David Miller
2009-07-27  6:07 ` [PATCH NEXT 11/12] netxen: support for ethtool set ringparam Dhananjay Phadke
2009-07-27 17:38   ` David Miller
2009-07-27  6:07 ` [PATCH NEXT 12/12] netxen: update version to 4.0.41 Dhananjay Phadke
2009-07-27 17:38   ` David Miller
2009-07-27 17:54     ` David Miller
2009-07-27 19:26       ` Dhananjay Phadke
2009-07-27 19:38         ` David Miller
2009-07-27 21:51           ` Dhananjay Phadke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248674867-18821-2-git-send-email-dhananjay@netxen.com \
    --to=dhananjay@netxen.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).