From: Marcel Holtmann <marcel@holtmann.org>
To: David Miller <davem@davemloft.net>
Cc: remi.denis-courmont@nokia.com, netdev@vger.kernel.org
Subject: Re: net-next-2.6 phonet causes build error
Date: Mon, 27 Jul 2009 17:18:29 +0200 [thread overview]
Message-ID: <1248707909.28545.200.camel@violet> (raw)
In-Reply-To: <20090727.080158.118098654.davem@davemloft.net>
Hi Dave,
> >> net/phonet/pn_dev.c: In function ‘phonet_init_net’:
> >> net/phonet/pn_dev.c:221: error: implicit declaration of function
> >> ‘proc_net_fops_create’
> >> net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
> >> net/phonet/pn_dev.c:242: error: implicit declaration of function
> >> ‘proc_net_remove’
> >
> > Oops. This makes me wonder why I did not get that one here on my test
> > builds???
>
> Because the headers on your platform with your configuration end up
> including linux/proc_fs.h indirectly.
this and similar automatic includes on x86 are still a problem. I always
try to compile test with a PPC based system, but even that architecture
has a lot of indirect includes. I would be happy if we could get rid of
these for x86 systems, but that seems a little bit wishful thinking.
Regards
Marcel
next prev parent reply other threads:[~2009-07-27 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-26 18:43 net-next-2.6 phonet causes build error Oliver Hartkopp
2009-07-26 20:39 ` David Miller
2009-07-27 6:27 ` Rémi Denis-Courmont
2009-07-27 7:03 ` Eric Dumazet
2009-07-27 8:06 ` Rémi Denis-Courmont
2009-07-27 8:09 ` Eric Dumazet
2009-07-28 2:31 ` David Miller
2009-07-28 6:18 ` Eric Dumazet
2009-07-27 15:03 ` David Miller
2009-07-27 15:01 ` David Miller
2009-07-27 15:18 ` Marcel Holtmann [this message]
2009-07-27 15:30 ` David Miller
2009-07-27 15:30 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248707909.28545.200.camel@violet \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).