From: Joe Perches <joe@perches.com>
To: Hannes Eder <heder@google.com>
Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Jan Engelhardt <jengelh@medozas.de>
Subject: Re: [PATCH 1/2] IPVS: use pr_fmt
Date: Tue, 28 Jul 2009 09:55:20 -0700 [thread overview]
Message-ID: <1248800120.6163.74.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20090728160536.12503.82355.stgit@jazzy.zrh.corp.google.com>
On Tue, 2009-07-28 at 18:06 +0200, Hannes Eder wrote:
> While being at it cleanup whitespace.
> diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
> index e01cc2d..99f09ab 100644
> --- a/include/net/ip_vs.h
> +++ b/include/net/ip_vs.h
> @@ -99,47 +99,47 @@ static inline const char *ip_vs_dbg_addr(int af, char *buf, size_t buf_len,
> return &buf[*idx - len];
> }
>
> -#define IP_VS_DBG_BUF(level, msg...) \
> - do { \
> - char ip_vs_dbg_buf[160]; \
> - int ip_vs_dbg_idx = 0; \
> - if (level <= ip_vs_get_debug_level()) \
> - printk(KERN_DEBUG "IPVS: " msg); \
> - } while (0)
[]
> +#define IP_VS_DBG_BUF(level, msg...) \
> + do { \
> + char ip_vs_dbg_buf[160]; \
> + int ip_vs_dbg_idx = 0; \
> + if (level <= ip_vs_get_debug_level()) \
> + pr_debug(msg); \
I think you should keep printk(KERN_DEBUG...) here and elsewhere.
Unless DEBUG is #defined, this won't print anything.
next prev parent reply other threads:[~2009-07-28 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 16:05 [PATCH 0/2] IPVS: make use of pr_fmt and friends Hannes Eder
2009-07-28 16:06 ` [PATCH 1/2] IPVS: use pr_fmt Hannes Eder
2009-07-28 16:55 ` Joe Perches [this message]
2009-07-28 16:06 ` [PATCH 2/2] IPVS: use pr_err and friends instead of IP_VS_ERR and friends Hannes Eder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248800120.6163.74.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=heder@google.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox