From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2 2/2] IPVS: use pr_err and friends instead of
 IP_VS_ERR and friends
Date: Tue, 28 Jul 2009 13:56:55 -0700
Message-ID: <1248814615.18284.22.camel@Joe-Laptop.home>
References: <20090728203414.7654.73236.stgit@jazzy.zrh.corp.google.com>
	 <20090728203554.7654.29628.stgit@jazzy.zrh.corp.google.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jan Engelhardt <jengelh@medozas.de>
To: Hannes Eder <heder@google.com>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1754554AbZG1U5A@vger.kernel.org>
In-Reply-To: <20090728203554.7654.29628.stgit@jazzy.zrh.corp.google.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Tue, 2009-07-28 at 22:35 +0200, Hannes Eder wrote:
> Since pr_err and friends is used instead of printk there is not point
> in keeping IP_VS_ERR and friends.
> +			pr_err("Schedule: port zero only supported "
> +			       "in persistent services, "
> +			       "check your ipvs configuration\n");

You might consider ignoring the checkpatch 80 char limit here
and consolidate the message into a single string.

It helps when grepping.

> @@ -377,8 +377,8 @@ static int ip_vs_svc_hash(struct ip_vs_service *svc)
>  static int ip_vs_svc_unhash(struct ip_vs_service *svc)
>  {
>  	if (!(svc->flags & IP_VS_SVC_F_HASHED)) {
> -		IP_VS_ERR("ip_vs_svc_unhash(): request for unhash flagged, "
> -			  "called from %p\n", __builtin_return_address(0));
> +		pr_err("ip_vs_svc_unhash(): request for unhash flagged, "
> +		       "called from %p\n", __builtin_return_address(0));

Maybe use something like:
	"%s(): <foo> called from %pf",
	 __func__, __builtin_return_address(0)