netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Ajit Khaparde <ajitk@serverengines.com>
Cc: davem@davemloft.net, jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net: Changes to support the "-f" option of ethtool.
Date: Wed, 05 Aug 2009 14:06:07 +0100	[thread overview]
Message-ID: <1249477567.2781.21.camel@achroite> (raw)
In-Reply-To: <20090805123704.GC6592@serverengines.com>

On Wed, 2009-08-05 at 18:07 +0530, Ajit Khaparde wrote:
> The patch intends to use the request_firmware() interface to pick the
> firmware image file. 
> I had missed this in the original post. Thanks.
[...]

Thanks for the clarification.

request_firmware() is meant for loading firmware that is stored in
volatile memory (RAM) on the device and therefore needs to be installed
on the host.

When the firmware is stored in flash on the device, updates only need to
be used once, and there should be no need to install them on the host.
So request_firmware() does not seem suitable.

I believe the ethtool EEPROM commands were meant for updating firmware
on NICs.  Although they assume random access and so are unsuitable for
flash-based firmware, they might be a better model for adding flash
update commands.  However, this command set is already available through
the MTD device class, which is what we use for firmware update as far as
possible.  Not only does this allow for an arbitrary number of separate
firmware partitions per network device, but it can be used in an
out-of-tree driver for older kernel versions.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  reply	other threads:[~2009-08-05 13:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05 12:32 [PATCH net-next-2.6] net: Changes to support the "-f" option of ethtool Ajit Khaparde
2009-08-05 12:37 ` Ajit Khaparde
2009-08-05 13:06   ` Ben Hutchings [this message]
2009-08-05 20:17     ` David Miller
2009-08-10  9:04       ` Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249477567.2781.21.camel@achroite \
    --to=bhutchings@solarflare.com \
    --cc=ajitk@serverengines.com \
    --cc=davem@davemloft.net \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).