From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shirley Ma Subject: Re: [PATCH] fix memory leak in virtio_net Date: Tue, 11 Aug 2009 09:56:23 -0700 Message-ID: <1250009784.4161.18.camel@localhost.localdomain> References: <1249934708.7400.10.camel@localhost.localdomain> <4A815B9A.3060205@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Rusty Russell To: Avi Kivity Return-path: Received: from e38.co.us.ibm.com ([32.97.110.159]:60809 "EHLO e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754808AbZHKQ4r (ORCPT ); Tue, 11 Aug 2009 12:56:47 -0400 In-Reply-To: <4A815B9A.3060205@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello Avi, I do see memory leak after removing virtio_net module. There is 72KB per removal along with free already free IRQ. Maybe the memleak from virtio_pci, seems some lock is missing when accessing the irq list? Trying to free already-free IRQ 26 Modules linked in: virtio_net(-) sunrpc ipv6 virtio_balloon pcspkr virtio_blk virtio_pci virtio_ring virtio [last unloaded: virtio_net] Pid: 1641, comm: rmmod Tainted: G W 2.6.31-rc4 #11 Call Trace: [] warn_slowpath_common+0x60/0x90 [] warn_slowpath_fmt+0x24/0x27 [] __free_irq+0x74/0x134 [] free_irq+0x8/0xf [] vp_free_vectors+0x42/0x97 [virtio_pci] [] vp_del_vqs+0xe0/0xe8 [virtio_pci] [] virtnet_remove+0xf9/0x125 [virtio_net] [] virtio_dev_remove+0xf/0x33 [virtio] [] __device_release_driver+0x58/0x8e [] driver_detach+0x5d/0x7b [] bus_remove_driver+0x63/0x89 [] driver_unregister+0x4d/0x54 [] unregister_virtio_driver+0x8/0xa [virtio] [] fini+0xd/0x12 [virtio_net] [] sys_delete_module+0x180/0x1d7 [] ? remove_vma+0x55/0x5b [] ? audit_syscall_entry+0x102/0x124 [] syscall_call+0x7/0xb When loading the module, the complain is: ------------[ cut here ]------------ WARNING: at lib/list_debug.c:26 __list_add+0x27/0x5c() Hardware name: list_add corruption. next->prev should be prev (df88b3e0), but was df466770. (next=dfbdb8d0). Modules linked in: virtio_net(+) sunrpc ipv6 virtio_balloon pcspkr virtio_blk virtio_pci virtio_ring virtio [last unloaded: virtio_net] Pid: 1674, comm: modprobe Tainted: G W 2.6.31-rc4 #11 Call Trace: [] warn_slowpath_common+0x60/0x90 [] warn_slowpath_fmt+0x24/0x27 [] __list_add+0x27/0x5c [] vp_find_vqs+0x47d/0x53c [virtio_pci] [] ? skb_recv_done+0x0/0x36 [virtio_net] [] virtnet_probe+0x24f/0x376 [virtio_net] [] ? skb_recv_done+0x0/0x36 [virtio_net] [] ? skb_xmit_done+0x0/0x3a [virtio_net] [] ? vp_set_status+0x20/0x22 [virtio_pci] [] ? add_status+0x1f/0x24 [virtio] [] virtio_dev_probe+0x91/0xb0 [virtio] [] driver_probe_device+0x79/0x105 [] __driver_attach+0x43/0x5f [] bus_for_each_dev+0x3d/0x67 [] driver_attach+0x14/0x16 [] ? __driver_attach+0x0/0x5f