From: Joe Perches <joe@perches.com>
To: Brian Haley <brian.haley@hp.com>
Cc: Jens Rosenboom <jens@mcbone.net>,
Linux Network Developers <netdev@vger.kernel.org>
Subject: Re: [RFC] ipv6: Change %pI6 format to output compacted addresses?
Date: Thu, 13 Aug 2009 03:39:21 -0700 [thread overview]
Message-ID: <1250159961.28285.35.camel@Joe-Laptop.home> (raw)
In-Reply-To: <4A836D6D.1040400@hp.com>
On Wed, 2009-08-12 at 21:33 -0400, Brian Haley wrote:
> Jens Rosenboom wrote:
> > Currently the output looks like 2001:0db8:0000:0000:0000:0000:0000:0001
> > which might be compacted to 2001:db8::1. The code to do this could be
> > adapted from inet_ntop in glibc, which would add about 80 lines to
> > lib/vsprintf.c. How do you guys value the tradeoff between more readable
> > logging and increased kernel size?
> >
> > This was already mentioned in
> > http://kerneltrap.org/mailarchive/linux-netdev/2008/11/25/4231684 but
> > noone seems to have taken up on it.
>
> Anyways, can you try this patch, it's less than 40 new lines :)
> It might be good enough, but could probably use some help.
You'll need to invent a new %p qualifier type to allow
compressed representation. Your patch will change current uses
with seq_<foo> output in net, which could break userspace.
next prev parent reply other threads:[~2009-08-13 10:39 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 15:39 [RFC] ipv6: Change %pI6 format to output compacted addresses? Jens Rosenboom
2009-08-13 1:33 ` Brian Haley
2009-08-13 10:39 ` Joe Perches [this message]
2009-08-13 13:52 ` Jens Rosenboom
2009-08-13 15:07 ` Joe Perches
2009-08-13 14:39 ` Jens Rosenboom
2009-08-13 15:14 ` Chuck Lever
2009-08-13 16:27 ` Brian Haley
2009-08-13 18:10 ` Joe Perches
2009-08-13 18:15 ` Chuck Lever
2009-08-13 18:21 ` Joe Perches
2009-08-13 18:39 ` Chuck Lever
2009-08-13 19:05 ` Joe Perches
2009-08-13 20:24 ` Brian Haley
2009-08-13 20:28 ` Brian Haley
2009-08-13 20:24 ` Brian Haley
2009-08-13 20:34 ` Joe Perches
2009-08-13 21:02 ` Chuck Lever
2009-08-13 21:13 ` Joe Perches
2009-08-13 23:31 ` David Miller
2009-08-14 6:22 ` Jens Rosenboom
2009-08-14 7:15 ` David Miller
2009-08-14 8:15 ` Jens Rosenboom
2009-08-14 20:12 ` David Miller
2009-08-15 15:24 ` [PATCH] lib/vsprintf.c: Add "%pI6c" - print pointer as compressed ipv6 address Joe Perches
2009-08-16 4:10 ` [RFC PATCH] lib/vsprintf.c: Add struct sockaddr * "%pN<foo>" output Joe Perches
2009-08-19 14:26 ` Chuck Lever
2009-08-19 20:44 ` [RFC PATCH V2] " Joe Perches
2009-08-19 22:20 ` Chuck Lever
2009-08-19 22:36 ` Joe Perches
2009-08-19 23:00 ` Chuck Lever
2009-08-20 4:24 ` Joe Perches
2009-08-20 4:29 ` David Miller
2009-08-17 15:18 ` [PATCH] lib/vsprintf.c: Add "%pI6c" - print pointer as compressed ipv6 address Jens Rosenboom
2009-08-17 22:29 ` [PATCH V2] " Joe Perches
2009-08-18 13:48 ` Jens Rosenboom
2009-08-29 7:20 ` David Miller
2009-08-14 16:26 ` [RFC] ipv6: Change %pI6 format to output compacted addresses? Chuck Lever
2009-08-13 14:18 ` Christoph Hellwig
2009-08-13 14:30 ` Jens Rosenboom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250159961.28285.35.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=brian.haley@hp.com \
--cc=jens@mcbone.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).