From: Jens Rosenboom <jens@mcbone.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Network Developers <netdev@vger.kernel.org>
Subject: Re: [RFC] ipv6: Change %pI6 format to output compacted addresses?
Date: Thu, 13 Aug 2009 16:30:40 +0200 [thread overview]
Message-ID: <1250173840.6641.81.camel@fnki-nb00130> (raw)
In-Reply-To: <20090813141840.GA25935@infradead.org>
On Thu, 2009-08-13 at 10:18 -0400, Christoph Hellwig wrote:
> On Wed, Aug 12, 2009 at 05:39:20PM +0200, Jens Rosenboom wrote:
> > Currently the output looks like 2001:0db8:0000:0000:0000:0000:0000:0001
> > which might be compacted to 2001:db8::1. The code to do this could be
> > adapted from inet_ntop in glibc, which would add about 80 lines to
> > lib/vsprintf.c. How do you guys value the tradeoff between more readable
> > logging and increased kernel size?
>
> A little note: if you borrow code from glibc always make sure it's from
> an old enough version that is still GPLv2+ licensed.
The code for inet_ntop has as comment
* author:
* Paul Vixie, 1996.
while the whole file is
Copyright (c) 1996-1999 by Internet Software Consortium.
so it should probably be old enough. But it also doesn't look too nice
to me, so I'll try to go without it for now.
prev parent reply other threads:[~2009-08-13 14:30 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 15:39 [RFC] ipv6: Change %pI6 format to output compacted addresses? Jens Rosenboom
2009-08-13 1:33 ` Brian Haley
2009-08-13 10:39 ` Joe Perches
2009-08-13 13:52 ` Jens Rosenboom
2009-08-13 15:07 ` Joe Perches
2009-08-13 14:39 ` Jens Rosenboom
2009-08-13 15:14 ` Chuck Lever
2009-08-13 16:27 ` Brian Haley
2009-08-13 18:10 ` Joe Perches
2009-08-13 18:15 ` Chuck Lever
2009-08-13 18:21 ` Joe Perches
2009-08-13 18:39 ` Chuck Lever
2009-08-13 19:05 ` Joe Perches
2009-08-13 20:24 ` Brian Haley
2009-08-13 20:28 ` Brian Haley
2009-08-13 20:24 ` Brian Haley
2009-08-13 20:34 ` Joe Perches
2009-08-13 21:02 ` Chuck Lever
2009-08-13 21:13 ` Joe Perches
2009-08-13 23:31 ` David Miller
2009-08-14 6:22 ` Jens Rosenboom
2009-08-14 7:15 ` David Miller
2009-08-14 8:15 ` Jens Rosenboom
2009-08-14 20:12 ` David Miller
2009-08-15 15:24 ` [PATCH] lib/vsprintf.c: Add "%pI6c" - print pointer as compressed ipv6 address Joe Perches
2009-08-16 4:10 ` [RFC PATCH] lib/vsprintf.c: Add struct sockaddr * "%pN<foo>" output Joe Perches
2009-08-19 14:26 ` Chuck Lever
2009-08-19 20:44 ` [RFC PATCH V2] " Joe Perches
2009-08-19 22:20 ` Chuck Lever
2009-08-19 22:36 ` Joe Perches
2009-08-19 23:00 ` Chuck Lever
2009-08-20 4:24 ` Joe Perches
2009-08-20 4:29 ` David Miller
2009-08-17 15:18 ` [PATCH] lib/vsprintf.c: Add "%pI6c" - print pointer as compressed ipv6 address Jens Rosenboom
2009-08-17 22:29 ` [PATCH V2] " Joe Perches
2009-08-18 13:48 ` Jens Rosenboom
2009-08-29 7:20 ` David Miller
2009-08-14 16:26 ` [RFC] ipv6: Change %pI6 format to output compacted addresses? Chuck Lever
2009-08-13 14:18 ` Christoph Hellwig
2009-08-13 14:30 ` Jens Rosenboom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250173840.6641.81.camel@fnki-nb00130 \
--to=jens@mcbone.net \
--cc=hch@infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox