* [PATCH] mdio: mdio_if_info::mmds should not be __bitwise
@ 2009-08-18 16:59 Ben Hutchings
2009-08-19 3:13 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2009-08-18 16:59 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-net-drivers
I misunderstood the meaning of __bitwise. In practice it makes sparse
warn about every use of mmds which is certainly not what we want.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
This should be safe to include in 2.6.31 but it's hardly critical.
Ben.
include/linux/mdio.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/mdio.h b/include/linux/mdio.h
index cfdf1df..c779b49 100644
--- a/include/linux/mdio.h
+++ b/include/linux/mdio.h
@@ -304,7 +304,7 @@ static inline __u16 mdio_phy_id_devad(int phy_id)
*/
struct mdio_if_info {
int prtad;
- u32 __bitwise mmds;
+ u32 mmds;
unsigned mode_support;
struct net_device *dev;
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mdio: mdio_if_info::mmds should not be __bitwise
2009-08-18 16:59 [PATCH] mdio: mdio_if_info::mmds should not be __bitwise Ben Hutchings
@ 2009-08-19 3:13 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-08-19 3:13 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 18 Aug 2009 17:59:38 +0100
> I misunderstood the meaning of __bitwise. In practice it makes sparse
> warn about every use of mmds which is certainly not what we want.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> This should be safe to include in 2.6.31 but it's hardly critical.
Applied to net-next-2.6, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-19 3:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-18 16:59 [PATCH] mdio: mdio_if_info::mmds should not be __bitwise Ben Hutchings
2009-08-19 3:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).