From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunbo Luo Subject: [PATCH 2/2] sctp: fix heartbeat count of path failure Date: Wed, 19 Aug 2009 15:01:08 +0800 Message-ID: <1250665268-29770-2-git-send-email-chunbo.luo@windriver.com> References: <1250665268-29770-1-git-send-email-chunbo.luo@windriver.com> Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, chunbo.luo@windriver.com To: davem@davemloft.net Return-path: Received: from mail.windriver.com ([147.11.1.11]:36897 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbZHSHBN (ORCPT ); Wed, 19 Aug 2009 03:01:13 -0400 In-Reply-To: <1250665268-29770-1-git-send-email-chunbo.luo@windriver.com> Sender: netdev-owner@vger.kernel.org List-ID: RFC4960 Section 8.2 defined that the transport should enter INACTIVE state only when the value in the error counter exceeds the protocol parameter 'Path.Max.Retrans' of that destination address. This means that the transport should enter INACTIVE state after pathmaxrxt+1 heartbeats are not acknowledged. Signed-off-by: Chunbo Luo --- net/sctp/sm_sideeffect.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c index 86426aa..0e2e269 100644 --- a/net/sctp/sm_sideeffect.c +++ b/net/sctp/sm_sideeffect.c @@ -447,7 +447,7 @@ static void sctp_do_8_2_transport_strike(struct sctp_association *asoc, asoc->overall_error_count++; if (transport->state != SCTP_INACTIVE && - (transport->error_count++ >= transport->pathmaxrxt)) { + (transport->error_count++ > transport->pathmaxrxt)) { SCTP_DEBUG_PRINTK_IPADDR("transport_strike:association %p", " transport IP: port:%d failed.\n", asoc, -- 1.6.4