From: Jens Rosenboom <jens@mcbone.net>
To: Frans Pop <elendil@planet.nl>
Cc: Danny Feng <dfeng@redhat.com>, Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH,v2] Re: e1000e: why does pci_enable_pcie_error_reporting() fail on my hp2510p?
Date: Fri, 21 Aug 2009 09:06:12 +0200 [thread overview]
Message-ID: <1250838372.9489.8.camel@fnki-nb00130> (raw)
In-Reply-To: <200908210848.39377.elendil@planet.nl>
On Fri, 2009-08-21 at 08:48 +0200, Frans Pop wrote:
[...]
> @@ -5301,9 +5296,6 @@ static void __devexit e1000_remove(struct pci_dev *pdev)
>
> /* AER disable */
> err = pci_disable_pcie_error_reporting(pdev);
> - if (err)
> - dev_err(&pdev->dev,
> - "pci_disable_pcie_error_reporting failed 0x%x\n", err);
>
> pci_disable_device(pdev);
> }
While you're at it, why don't you also remove the "err =" here, which
allows you to drop the variable from that function completely? This
applies to all three *_remove() functions.
next prev parent reply other threads:[~2009-08-21 7:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 15:14 e1000e: why does pci_enable_pcie_error_reporting() fail on my hp2510p? Frans Pop
2009-08-20 19:25 ` Bjørn Mork
2009-08-21 2:08 ` Danny Feng
2009-08-21 6:29 ` [PATCH] " Frans Pop
2009-08-21 6:33 ` Danny Feng
2009-08-21 6:48 ` [PATCH,v2] " Frans Pop
2009-08-21 6:52 ` David Miller
2009-08-21 7:01 ` Jeff Kirsher
2009-08-21 7:06 ` Jens Rosenboom [this message]
2009-08-21 7:39 ` [PATCH,v3] " Frans Pop
2009-09-02 1:18 ` [PATCH,v2] " Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250838372.9489.8.camel@fnki-nb00130 \
--to=jens@mcbone.net \
--cc=davem@davemloft.net \
--cc=dfeng@redhat.com \
--cc=elendil@planet.nl \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox