public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: DDD <Dongdong.deng@windriver.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] smc91x: fix compilation on SMP
Date: Wed, 26 Aug 2009 17:39:58 +0800	[thread overview]
Message-ID: <1251279598.7267.21.camel@dengdd-desktop> (raw)
In-Reply-To: <20090826085526.GA3209@x200.localdomain>

Hi Alexey,

Thanks for you correct me. :-)

For "smc91x", I just compile it on an old linux version, and merge the
changes to the latest linux for creating a patch. 
I think it must be OK, so I didn't compile the patch on the latest
linux. 

I'm so sorry for my careless.


Dongdong


On Wed, 2009-08-26 at 12:55 +0400, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  drivers/net/smc91x.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/net/smc91x.c
> +++ b/drivers/net/smc91x.c
> @@ -531,7 +531,7 @@ static inline void  smc_rcv(struct net_device *dev)
>  		local_irq_restore(flags);				\
>  	__ret;								\
>  })
> -#define smc_special_lock(lock, flags)		spin_lock_irq(lock, flags)
> +#define smc_special_lock(lock, flags)		spin_lock_irqsave(lock, flags)
>  #define smc_special_unlock(lock, flags) 	spin_unlock_irqrestore(lock, flags)
>  #else
>  #define smc_special_trylock(lock, flags)	(1)

  reply	other threads:[~2009-08-26  9:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-26  8:55 [PATCH] smc91x: fix compilation on SMP Alexey Dobriyan
2009-08-26  9:39 ` DDD [this message]
2009-08-26 19:03 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1251279598.7267.21.camel@dengdd-desktop \
    --to=dongdong.deng@windriver.com \
    --cc=adobriyan@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox