From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Dillow Subject: Re: [PATCH] r8169: Reduce looping in the interrupt handler. Date: Thu, 27 Aug 2009 21:29:38 -0400 Message-ID: <1251422978.21865.2.camel@obelisk.thedillows.org> References: <20090825221903.GA13630@electric-eye.fr.zoreil.com> <1251294974.14241.9.camel@obelisk.thedillows.org> <1251295175.14241.11.camel@obelisk.thedillows.org> <20090826213024.GA20428@electric-eye.fr.zoreil.com> <20090827052423.GA1709@electric-eye.fr.zoreil.com> <20090827232024.GA30119@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Francois Romieu , Michael Riepe , Michael Buesch , Rui Santos , Michael B??ker , linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: "Eric W. Biederman" Return-path: Received: from smtp.knology.net ([24.214.63.101]:34826 "EHLO smtp.knology.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbZH1B3k (ORCPT ); Thu, 27 Aug 2009 21:29:40 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2009-08-27 at 18:17 -0700, Eric W. Biederman wrote: > Francois Romieu writes: > > > Eric W. Biederman : > > [...] > >> Sounds good. > > > > Gah, I was not able to test it with a decent packet load. Patch below against > > the current tree: > > This kills the loop which was my concern. > > I will double check it works on my configuration. > Then we have the question of does it work for those folks who have cards > where the msi appeared to get lost. > > David any chance you can test this patch? It'll be this weekend, but I can see cases where it can lock my chip up -- they should be rare, but then I thought your case would be extremely rare... I think we'll need to go to a full separation between MSI and level-triggered interrupt handlers, or at the very least mask everything and handle it all in NAPI. That seems more viable now that I know Francois is not terribly worried about diverging from the vendor driver there.