From: Peter Wu <lekensteyn@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [PATCH] r8169: fix invalid register dump
Date: Sat, 17 Aug 2013 00:58:03 +0200 [thread overview]
Message-ID: <125169438.hchJeoqxoY@al> (raw)
In-Reply-To: <1376598795.11042.1.camel@deadeye.wl.decadent.org.uk>
On Thursday 15 August 2013 22:33:15 Ben Hutchings wrote:
> The kernel buffer size is max(regs->len,
> dev->ethtool_ops->get_regs_len()). So you can safely ignore regs->len
> and always read all your registers.
I see, that is something for a different patch though. While I am at it,
I checked all users of get_regs_len in drivers/net and found only one
other user that also checked the length. Patch will follow shortly.
prev parent reply other threads:[~2013-08-17 0:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 20:37 [PATCH] r8169: fix invalid register dump Peter Wu
2013-08-13 22:20 ` Francois Romieu
2013-08-14 13:12 ` Peter Wu
2013-08-14 19:58 ` Francois Romieu
2013-08-14 21:31 ` Peter Wu
2013-08-14 22:47 ` Francois Romieu
2013-08-16 22:35 ` Peter Wu
2013-08-15 20:33 ` Ben Hutchings
2013-08-16 22:58 ` Peter Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=125169438.hchJeoqxoY@al \
--to=lekensteyn@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox