From: Marcel Holtmann <marcel@holtmann.org>
To: Brian Haley <brian.haley@hp.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] netlink: silence compiler warning
Date: Sat, 05 Sep 2009 03:08:01 +0200 [thread overview]
Message-ID: <1252112881.27694.3.camel@violet> (raw)
In-Reply-To: <4AA1B712.6060900@hp.com>
Hi Brian,
> CC net/netlink/genetlink.o
> net/netlink/genetlink.c: In function ‘genl_register_mc_group’:
> net/netlink/genetlink.c:139: warning: ‘err’ may be used uninitialized in this function
>
> From following the code 'err' is initialized, but set it to zero to
> silence the warning.
>
> Signed-off-by: Brian Haley <brian.haley@hp.com>
> ---
>
> diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
> index 575c643..66f6ba0 100644
> --- a/net/netlink/genetlink.c
> +++ b/net/netlink/genetlink.c
> @@ -136,7 +136,7 @@ int genl_register_mc_group(struct genl_family *family,
> {
> int id;
> unsigned long *new_groups;
> - int err;
> + int err = 0;
>
> BUG_ON(grp->name[0] == '\0');
can we please add the err = -E... where it actually is needed and not
stupidly go ahead and silence compiler warnings with err = 0. This has
been posted before.
Regards
Marcel
next prev parent reply other threads:[~2009-09-05 1:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-05 0:55 [PATCH] netlink: silence compiler warning Brian Haley
2009-09-05 1:08 ` Marcel Holtmann [this message]
2009-09-05 1:36 ` Brian Haley
2009-09-05 3:33 ` David Miller
2009-09-05 7:52 ` Jarek Poplawski
2009-09-05 8:13 ` David Miller
2009-09-05 3:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252112881.27694.3.camel@violet \
--to=marcel@holtmann.org \
--cc=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).