From: Marcel Holtmann <marcel@holtmann.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
johannes@sipsolutions.net
Subject: Re: [PATCH] net: Add DEVTYPE support for Ethernet based devices
Date: Sat, 05 Sep 2009 06:34:00 +0200 [thread overview]
Message-ID: <1252125240.27694.5.camel@violet> (raw)
In-Reply-To: <20090904.202750.249172306.davem@davemloft.net>
Hi Dave,
> > can you please give me some feedback on this patch.
>
> Johannes recommended using a NETDEV_REGISTER hook, I'm
> waiting for you to try and use that instead of this
> patch.
that was for the Wireless drivers part. Total different from what this
patch trying to achieve.
> Your patch is ugly, so I'd like to avoid it if possible.
What is ugly about it. Do you have any other recommendation on how let
userspace know what type of Ethernet device it is?
Regards
Marcel
next prev parent reply other threads:[~2009-09-05 4:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 7:08 [PATCH] net: Add DEVTYPE support for Ethernet based devices Marcel Holtmann
2009-09-01 7:25 ` Johannes Berg
2009-09-01 7:33 ` Marcel Holtmann
2009-09-05 0:17 ` Marcel Holtmann
2009-09-05 3:27 ` David Miller
2009-09-05 4:34 ` Marcel Holtmann [this message]
2009-09-05 4:46 ` David Miller
2009-09-05 5:52 ` Marcel Holtmann
2009-09-05 5:55 ` David Miller
2009-09-05 4:49 ` Stephen Hemminger
2009-09-05 5:55 ` Marcel Holtmann
2009-09-11 19:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252125240.27694.5.camel@violet \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).