* [PATCH] tg3: Fix return ring size breakage
@ 2009-09-11 23:23 mcarlson
2009-09-11 23:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: mcarlson @ 2009-09-11 23:23 UTC (permalink / raw)
To: davem; +Cc: netdev, andy
Commit f6eb9b1fc1411d22c073f5264e5630a541d0f7df, "tg3: Add 5717 asic
rev" changed how the rx return ring size operations are done. It
effectively inverts the sense of the previous test, but it failed to
also invert the resulting sizes. This patch corrects that error.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
---
drivers/net/tg3.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 7cf8000..f09bc5d 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -112,7 +112,7 @@
*/
#define TG3_RX_RCB_RING_SIZE(tp) \
(((tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) && \
- !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) ? 512 : 1024)
+ !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) ? 1024 : 512)
#define TG3_TX_RING_SIZE 512
#define TG3_DEF_TX_RING_PENDING (TG3_TX_RING_SIZE - 1)
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tg3: Fix return ring size breakage
2009-09-11 23:23 [PATCH] tg3: Fix return ring size breakage mcarlson
@ 2009-09-11 23:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-09-11 23:57 UTC (permalink / raw)
To: mcarlson; +Cc: netdev, andy
From: mcarlson <mcarlson@broadcom.com>
Date: Fri, 11 Sep 2009 16:23:19 -0700
> Commit f6eb9b1fc1411d22c073f5264e5630a541d0f7df, "tg3: Add 5717 asic
> rev" changed how the rx return ring size operations are done. It
> effectively inverts the sense of the previous test, but it failed to
> also invert the resulting sizes. This patch corrects that error.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Confirmed to fix things here, applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-11 23:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-11 23:23 [PATCH] tg3: Fix return ring size breakage mcarlson
2009-09-11 23:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).