netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
	jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
	gospo@redhat.com, gregory.v.rose@intel.com,
	donald.c.skidmore@intel.com
Subject: Re: [net-next PATCH] etherdevice.h: random_ether_addr update
Date: Fri, 11 Sep 2009 17:57:47 -0700	[thread overview]
Message-ID: <1252717067.29420.22.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20090911141554.0072d365@nehalam>

On Fri, 2009-09-11 at 14:15 -0700, Stephen Hemminger wrote:
> On Fri, 2009-09011 at 13:20 -0700 Joe Perches wrote:
> > Do not use get_random_bytes to avoid drawing down entropy pool.
> Getting 6 bytes once is not going to be enough of a problem
> to drain the pool. I prefer not to weaken the randomness here.

I see no reason to draw down the entropy pool.

I have a hard time imagining that a random mac address
needs more than reasonably random values.

Why do you think it's reasonable to draw from the
entropy pool?

cheers, Joe


  reply	other threads:[~2009-09-12  0:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11  1:48 [net-next PATCH] igb: Use Intel OUI for VF MAC addresses Jeff Kirsher
2009-09-11  2:07 ` Stephen Hemminger
2009-09-11  3:02   ` Joe Perches
2009-09-11 19:15     ` David Miller
2009-09-11 20:20       ` [net-next PATCH] etherdevice.h: random_ether_addr update Joe Perches
2009-09-11 20:44         ` [net-next PATCH V2] " Joe Perches
2009-09-11 21:13           ` Rose, Gregory V
2009-09-11 21:15         ` [net-next PATCH] " Stephen Hemminger
2009-09-12  0:57           ` Joe Perches [this message]
2009-09-13  0:14             ` Mark Smith
2009-09-13  0:33               ` Mark Smith
2009-09-13  0:44                 ` Joe Perches
2009-09-13  3:47                   ` Mark Smith
2009-09-13  6:09                     ` Joe Perches
2009-09-13  6:39                       ` Mark Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252717067.29420.22.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=donald.c.skidmore@intel.com \
    --cc=gospo@redhat.com \
    --cc=gregory.v.rose@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).