From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: David Miller <davem@davemloft.net>,
Gabriele Paoloni <gabriele.paoloni@intel.com>,
Paul Mackerras <paulus@samba.org>,
linux-ppp@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: [PATCH] ppp: ppp_generic.c initialize flen before it get used
Date: Sat, 12 Sep 2009 22:11:31 +0530 [thread overview]
Message-ID: <1252773691.3687.5.camel@ht.satnam> (raw)
When while loop runs first time flen is used uninitialized for nfree <= 0
This also fixed compilation warning :
CC [M] drivers/net/ppp_generic.o
drivers/net/ppp_generic.c: In function ‘ppp_mp_explode’:
drivers/net/ppp_generic.c:1314: warning: ‘flen’ may be used uninitialized in this function
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
drivers/net/ppp_generic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c
index cd37d73..b1a1a06 100644
--- a/drivers/net/ppp_generic.c
+++ b/drivers/net/ppp_generic.c
@@ -1311,7 +1311,7 @@ static int ppp_mp_explode(struct ppp *ppp, struct sk_buff *skb)
{
int len, totlen;
int i, bits, hdrlen, mtu;
- int flen;
+ int flen = 0;
int navail, nfree, nzero;
int nbigger;
int totspeed;
--
1.6.4.2
next reply other threads:[~2009-09-12 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-12 16:41 Jaswinder Singh Rajput [this message]
2009-09-13 6:17 ` [PATCH] ppp: ppp_generic.c initialize flen before it get used David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252773691.3687.5.camel@ht.satnam \
--to=jaswinder@kernel.org \
--cc=davem@davemloft.net \
--cc=gabriele.paoloni@intel.com \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox