From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Walker Subject: Re: [Patch net-next]atl1e:fix 2.6.31-git4 -- ATL1E 0000:03:00.0: DMA-API: device driver frees DMA Date: Wed, 16 Sep 2009 02:10:51 -0700 Message-ID: <1253092251.11643.569.camel@desktop> References: <12530821133392-git-send-email-jie.yang@atheros.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, miles.lane@gmail.com, chris.snook@gmail.com, jcliburn@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: jie.yang@atheros.com Return-path: In-Reply-To: <12530821133392-git-send-email-jie.yang@atheros.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 2009-09-16 at 14:21 +0800, jie.yang@atheros.com wrote: > - pci_unmap_page(pdev, tx_buffer->dma, > + if (tx_buffer->flags & ATL1E_TX_PCIMAP_SINGLE) > + pci_unmap_single(pdev, tx_buffer->dma, > + tx_buffer->length, PCI_DMA_TODEVICE); > + else if (tx_buffer->flags & ATL1E_TX_PCIMAP_PAGE) > + pci_unmap_page(pdev, tx_buffer->dma, Could you run this through checkpatch, and fix any errors if find? It looks like you uses spaces for tabs in the code above, maybe in the other block too.. Daniel