From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/2] net/netfilter/ipvs: Move #define KMSG_COMPONENT to Makefile Date: Wed, 30 Sep 2009 17:50:35 -0700 Message-ID: <1254358235.2960.145.camel@Joe-Laptop.home> References: <0026bcf5aad9ae5036e68fc2dcda9c778d30dc47.1254349375.git.joe@perches.com> <1254352160.2960.119.camel@Joe-Laptop.home> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Patrick McHardy , "David S. Miller" , Simon Horman , Julian Anastasov , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvs-devel@vger.kernel.org To: Jan Engelhardt Return-path: In-Reply-To: Sender: lvs-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 2009-10-01 at 02:31 +0200, Jan Engelhardt wrote: > KBUILD_MODNAME is special in that it is derived from the actual > source filename. Kind of. It's derived from the module name, not the filename. > Of course you could put #define KBUILD_MODNAME "foo" > in your source file, but that is like putting changelogs there > when they belong into the git log. I agree with that. > Well I personally prefer the #include instead of hiding such in > Makefiles. You know, when newcomers could start doing `grep > KMSG_COMPONENT *.[ch]`. Perhaps GCC's -include flag in a Makefile > to avoid #includes in .c files? I imagine an eventual goal of standardizing the default pr_fmt define in kernel.h to #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt so that all pr_ calls get this unless otherwise specified. Or perhaps better, to get rid of pr_fmt(fmt) altogether and have printk emit the filename/modulename, function and/or code offset by using something like %pS after the level. I see the Makefile use, which I don't really like too much because of the information hiding, as an intermediate step until that's possible.