From: Ben Hutchings <bhutchings@solarflare.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Kalle Valo <kalle.valo@nokia.com>, Kalle Valo <kalle.valo@iki.fi>,
"Luis R. Rodriguez" <mcgrof@gmail.com>
Subject: Re: [PATCH 3/3] at76c50x-usb: set firmware and hardware version in wiphy
Date: Thu, 01 Oct 2009 02:32:27 +0100 [thread overview]
Message-ID: <1254360747.23350.2.camel@localhost> (raw)
In-Reply-To: <1254359942-3483-3-git-send-email-linville@tuxdriver.com>
On Wed, 2009-09-30 at 21:19 -0400, John W. Linville wrote:
[...]
> + len = sizeof(wiphy->fw_version);
> + snprintf(wiphy->fw_version, len, "%d.%d.%d-%d",
> + priv->fw_version.major, priv->fw_version.minor,
> + priv->fw_version.patch, priv->fw_version.build);
> + /* null terminate the strings in case they were truncated */
> + wiphy->fw_version[len - 1] = '\0';
[...]
This last statement is unnecessary; snprintf() always null-terminates
(unless the length is zero).
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-10-01 1:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090924180048.14503.9579.stgit@tikku>
[not found] ` <43e72e890909241320j592e347die8a14f8bdd962ffb@mail.gmail.com>
[not found] ` <20090925044258.GA2722@tuxdriver.com>
[not found] ` <da94abde0909250947k5084db85vccafe0d3e74e2ecf@mail.gmail.com>
[not found] ` <43e72e890909250953r1714c79bsa679b96ca6f5797@mail.gmail.com>
2009-10-01 1:13 ` [PATCH 0/2] cfg80211: firmware and hardware version John W. Linville
[not found] ` <20091001011340.GA3123-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2009-10-01 1:19 ` [PATCH 1/3] wireless: implement basic ethtool support for cfg80211 devices John W. Linville
2009-10-01 1:19 ` [PATCH 2/3] cfg80211: add firmware and hardware version to wiphy John W. Linville
[not found] ` <1254359942-3483-2-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2009-10-01 1:19 ` [PATCH 3/3] at76c50x-usb: set firmware and hardware version in wiphy John W. Linville
2009-10-01 1:32 ` Ben Hutchings [this message]
2009-10-01 14:27 ` Kalle Valo
2009-10-01 1:30 ` [PATCH 1/3] wireless: implement basic ethtool support for cfg80211 devices Ben Hutchings
[not found] ` <1254359942-3483-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2009-10-01 8:51 ` Johannes Berg
2009-10-01 14:18 ` [PATCH 0/2] cfg80211: firmware and hardware version Kalle Valo
2009-10-01 15:18 ` John W. Linville
2009-10-01 15:33 ` Ben Hutchings
2009-10-01 16:56 ` John W. Linville
2009-10-01 16:20 ` Kalle Valo
2009-10-01 17:07 ` John W. Linville
[not found] ` <20091001170722.GC2895-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2009-10-01 19:56 ` Luis R. Rodriguez
2009-10-01 20:12 ` Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254360747.23350.2.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=kalle.valo@iki.fi \
--cc=kalle.valo@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).