From: Ben Hutchings <bhutchings@solarflare.com>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: export device speed and duplex via sysfs
Date: Fri, 02 Oct 2009 19:19:14 +0100 [thread overview]
Message-ID: <1254507554.8795.12.camel@achroite> (raw)
In-Reply-To: <20091002180742.GH4436@gospo.rdu.redhat.com>
On Fri, 2009-10-02 at 14:07 -0400, Andy Gospodarek wrote:
> This exports the link-speed (in Mbps) and duplex of an interface via
> sysfs. This eliminates the need to use ethtool just to check the
> link-speed. Not requiring 'ethtool' and not relying on the SIOCETHTOOL
> ioctl should be helpful in an embedded environment where space is at a
> premium as well.
It's trivial to write an ethtool-lite that does this. That might be
worth adding to busybox.
> NOTE: This patch also intentionally allows non-root users to check the link
> speed and duplex -- something not possible with ethtool.
[...]
Assuming this is desirable (I'm not sure), wouldn't it would make more
sense to move the permissions check for SIOCETHTOOL so that get_settings
is non-privileged?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-10-02 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 18:07 [PATCH] net: export device speed and duplex via sysfs Andy Gospodarek
2009-10-02 18:15 ` Eric Dumazet
2009-10-02 19:26 ` [PATCH v2] " Andy Gospodarek
2009-10-02 18:19 ` Ben Hutchings [this message]
2009-10-02 20:01 ` [PATCH] " Andy Gospodarek
2009-10-05 7:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254507554.8795.12.camel@achroite \
--to=bhutchings@solarflare.com \
--cc=andy@greyhouse.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).