From: Ben Hutchings <bhutchings@solarflare.com>
To: Brice Goglin <brice@myri.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Network Development list <netdev@vger.kernel.org>
Subject: Re: [PATCH] myri10ge: improve port type reporting in ethtool output
Date: Mon, 19 Oct 2009 09:12:09 +0100 [thread overview]
Message-ID: <1255939929.3916.13.camel@localhost> (raw)
In-Reply-To: <4ADBFA88.8030300@myri.com>
On Mon, 2009-10-19 at 07:35 +0200, Brice Goglin wrote:
> Improve the reporting of the port type in ethtool,
> update for new boards.
>
> Signed-off-by: Brice Goglin <brice@myri.com>
>
> --- a/drivers/net/myri10ge/myri10ge.c
> +++ b/drivers/net/myri10ge/myri10ge.c
> @@ -75,7 +75,7 @@
> #include "myri10ge_mcp.h"
> #include "myri10ge_mcp_gen_header.h"
>
> -#define MYRI10GE_VERSION_STR "1.5.0-1.432"
> +#define MYRI10GE_VERSION_STR "1.5.1-1.450"
>
> MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
> MODULE_AUTHOR("Maintainer: help@myri.com");
> @@ -1601,6 +1601,8 @@ myri10ge_get_settings(struct net_device *netdev,
> struct ethtool_cmd *cmd)
> cmd->autoneg = AUTONEG_DISABLE;
> cmd->speed = SPEED_10000;
> cmd->duplex = DUPLEX_FULL;
> + cmd->supported = SUPPORTED_10000baseT_Full;
> + cmd->advertising = ADVERTISED_10000baseT_Full;
[...]
Lying about link modes is not an improvement.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-10-19 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 5:35 [PATCH] myri10ge: improve port type reporting in ethtool output Brice Goglin
2009-10-19 8:12 ` Ben Hutchings [this message]
2009-10-19 12:34 ` Andrew Gallatin
2009-10-19 13:03 ` Ben Hutchings
2009-10-19 13:30 ` Andrew Gallatin
2009-10-19 14:17 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255939929.3916.13.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=brice@myri.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).