From: "Eilon Greenstein" <eilong@broadcom.com>
To: "kirjanov@gmail.com" <kirjanov@gmail.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH]bnx2x: remove duplication of the BCM_VLAN macro
Date: Thu, 22 Oct 2009 09:42:47 +0200 [thread overview]
Message-ID: <1256197367.4101.22.camel@lb-tlvb-eilong> (raw)
In-Reply-To: <20091021203851.GA5311@coldcone>
On Wed, 2009-10-21 at 13:38 -0700, Denis Kirjanov
> File bnx2.c already contains condition of the macro inclusion.
> So we can remove this.
It is true that BCM_VLAN is defined in bnx2.c, however it is not defined
in bnx2x_*.c files. The definition in bnx2x.h is needed for the bnx2x.ko
module.
Please do not remove it.
Thanks,
Eilon
> Signed-off-by: Denis Kirjanov <kirjanov@gmail.com>
> ---
>
> diff --git a/drivers/net/bnx2x.h b/drivers/net/bnx2x.h
> index bbf8422..4b99fd2 100644
> --- a/drivers/net/bnx2x.h
> +++ b/drivers/net/bnx2x.h
> @@ -20,10 +20,6 @@
> * (you will need to reboot afterwards) */
> /* #define BNX2X_STOP_ON_ERROR */
>
> -#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
> -#define BCM_VLAN 1
> -#endif
> -
>
> #define BNX2X_MULTI_QUEUE
>
prev parent reply other threads:[~2009-10-22 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 20:38 [PATCH]bnx2x: remove duplication of the BCM_VLAN macro Denis Kirjanov <kirjanov@gmail.com
2009-10-22 7:42 ` Eilon Greenstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256197367.4101.22.camel@lb-tlvb-eilong \
--to=eilong@broadcom.com \
--cc=davem@davemloft.net \
--cc=kirjanov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).