From: "Antti Kaijanmäki" <antti.kaijanmaki@nomovok.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jan Dumon <j.dumon@option.com>
Subject: [PATCH] hso: fix debug routines
Date: Tue, 27 Oct 2009 16:26:55 +0200 [thread overview]
Message-ID: <1256653615.3591.113.camel@nomovok.homedomain> (raw)
In-Reply-To: <20091026194058.GA25263@kroah.com>
On Mon, 2009-10-26 at 12:40 -0700, Greg KH wrote:
> Yes, that should be a new patch, especially as it would not be needed
> to fix older kernels for the original bug.
>
> So, care to send 2 patches? The debug one isn't needed to be sent to
> the stable@kernel.org address.
Signed-off-by: Antti Kaijanmäki <antti.kaijanmaki@nomovok.com>
---
drivers/net/usb/hso.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index fa4e581..746839b 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -378,7 +378,7 @@ static void dbg_dump(int line_count, const char *func_name, unsigned char *buf,
}
#define DUMP(buf_, len_) \
- dbg_dump(__LINE__, __func__, buf_, len_)
+ dbg_dump(__LINE__, __func__, (unsigned char *)buf_, len_)
#define DUMP1(buf_, len_) \
do { \
@@ -1527,7 +1527,7 @@ static void tiocmget_intr_callback(struct urb *urb)
dev_warn(&usb->dev,
"hso received invalid serial state notification\n");
DUMP(serial_state_notification,
- sizeof(hso_serial_state_notifation))
+ sizeof(struct hso_serial_state_notification));
} else {
UART_state_bitmap = le16_to_cpu(serial_state_notification->
--
1.6.3.3
next parent reply other threads:[~2009-10-27 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1256200578.3057.113.camel@nomovok.homedomain>
[not found] ` <20091026171550.GA24910@kroah.com>
[not found] ` <1256585855.3591.52.camel@nomovok.homedomain>
[not found] ` <20091026194058.GA25263@kroah.com>
2009-10-27 14:26 ` Antti Kaijanmäki [this message]
2009-10-28 23:16 ` [PATCH] hso: fix debug routines Andrew Morton
2009-10-29 6:57 ` Antti Kaijanmäki
2009-10-27 14:26 ` [PATCH] hso: fix soft-lockup Antti Kaijanmäki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256653615.3591.113.camel@nomovok.homedomain \
--to=antti.kaijanmaki@nomovok.com \
--cc=greg@kroah.com \
--cc=j.dumon@option.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox