netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gilad Ben-Yossef <gilad@codefidence.com>
To: netdev@vger.kernel.org
Cc: ori@comsleep.com
Subject: [PATCHv4 1/7] Only parse time stamp TCP option in time wait sock
Date: Wed, 28 Oct 2009 16:15:21 +0200	[thread overview]
Message-ID: <1256739327-11576-2-git-send-email-gilad@codefidence.com> (raw)
In-Reply-To: <1256739327-11576-1-git-send-email-gilad@codefidence.com>

Since we only use tcp_parse_options here to check for the exietence
of TCP timestamp option in the header, it is better to call with
the "established" flag on.

Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com>
Signed-off-by: Ori Finkelman <ori@comsleep.com>
Signed-off-by: Yony Amit <yony@comsleep.com>
---
 net/ipv4/tcp_minisocks.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
index 624c3c9..8c8c6e6 100644
--- a/net/ipv4/tcp_minisocks.c
+++ b/net/ipv4/tcp_minisocks.c
@@ -100,9 +100,9 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb,
 	struct tcp_options_received tmp_opt;
 	int paws_reject = 0;
 
-	tmp_opt.saw_tstamp = 0;
 	if (th->doff > (sizeof(*th) >> 2) && tcptw->tw_ts_recent_stamp) {
-		tcp_parse_options(skb, &tmp_opt, 0);
+		tmp_opt.tstamp_ok = 1;
+		tcp_parse_options(skb, &tmp_opt, 1);
 
 		if (tmp_opt.saw_tstamp) {
 			tmp_opt.ts_recent	= tcptw->tw_ts_recent;
-- 
1.5.6.3


  reply	other threads:[~2009-10-28 14:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-28 14:15 [PATCHv4 0/7] Per route TCP options support kill switches Gilad Ben-Yossef
2009-10-28 14:15 ` Gilad Ben-Yossef [this message]
2009-10-28 14:15 ` [PATCHv4 2/7] Allow tcp_parse_options to consult dst entry Gilad Ben-Yossef
2009-10-28 14:15 ` [PATCHv4 3/7] Add dst_feature to query route entry features Gilad Ben-Yossef
2009-10-28 14:15 ` [PATCHv4 4/7] Add the no SACK route option feature Gilad Ben-Yossef
2009-10-28 14:15 ` [PATCHv4 5/7] Allow disabling TCP timestamp options per route Gilad Ben-Yossef
2009-10-28 14:15 ` [PATCHv4 6/7] Allow to turn off TCP window scale opt " Gilad Ben-Yossef
2009-10-28 14:15 ` [PATCHv4 7/7] Allow disabling of DSACK TCP option " Gilad Ben-Yossef
2009-10-28 14:22 ` [PATCHv4 0/7] Per route TCP options support kill switches Eric Dumazet
2009-10-28 14:31   ` Gilad Ben-Yossef
2009-10-29  8:29 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256739327-11576-2-git-send-email-gilad@codefidence.com \
    --to=gilad@codefidence.com \
    --cc=netdev@vger.kernel.org \
    --cc=ori@comsleep.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).