From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCHv2] gro: Name the GRO result enumeration type
Date: Fri, 30 Oct 2009 11:48:18 +0000 [thread overview]
Message-ID: <1256903298.3136.261.camel@localhost> (raw)
In-Reply-To: <20091029.213223.94736944.davem@davemloft.net>
On Thu, 2009-10-29 at 21:32 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Thu, 29 Oct 2009 18:26:15 +0000
>
> > This clarifies which return and parameter types are GRO result codes
> > and not RX result codes.
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> > ---
> > This replaces the previous patch 1/4 and avoids introducing compiler
> > warnings. The original patches 2-4 will still apply on top of it.
>
> You can't do this Ben.
>
> Changing this patch makes the follow-on patches not apply cleanly.
[...]
I'm sorry about that - a git rebase succeeded without manual attention,
so I believed they did.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2009-10-30 11:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 17:17 [PATCH 1/4] gro: Name the GRO result enumeration type Ben Hutchings
2009-10-29 17:48 ` Herbert Xu
2009-10-30 4:29 ` David Miller
2009-10-29 18:14 ` Ben Hutchings
2009-10-29 18:26 ` [PATCHv2] " Ben Hutchings
2009-10-30 4:32 ` David Miller
2009-10-30 11:48 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256903298.3136.261.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).