netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, j@w1.fi, tgraf@suug.ch
Subject: Re: [RFC] netlink: add socket destruction notification
Date: Fri, 06 Nov 2009 09:55:52 +0100	[thread overview]
Message-ID: <1257497752.29454.11.camel@johannes.local> (raw)
In-Reply-To: <20091105.210806.40981707.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

On Thu, 2009-11-05 at 21:08 -0800, David Miller wrote:

> > When we want to keep track of resources associated with applications, we
> > need to know when an app is going away. Add a notification function to
> > netlink that tells us that, and also hook it up to generic netlink so
> > generic netlink can notify the families. Due to the way generic netlink
> > works though, we need to notify all families and they have to sort out
> > whatever resources some commands associated with the socket themselves.

> No fundamental objections.

:)

> However, as a followup, netlink_kernel_create() is becomming
> function_that_takes_too_many_arguments().
> 
> At this point it's better to just pass two arguments, the network
> namespace pointer, and a pointer to a "const struct netlink_kern_info"
> that holds the rest of the parameters.
> 
> Could you make that change too?

Yeah, I agree -- will change.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2009-11-06  8:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02  8:44 [RFC] netlink: add socket destruction notification Johannes Berg
2009-11-06  5:08 ` David Miller
2009-11-06  8:55   ` Johannes Berg [this message]
2009-11-06 15:21 ` Patrick McHardy
2009-11-06 15:26   ` Johannes Berg
2009-11-06 15:37     ` Patrick McHardy
2009-11-09 10:22       ` Johannes Berg
2009-11-09 12:59         ` Patrick McHardy
2009-11-09 13:03           ` Johannes Berg
2009-11-09 13:19             ` Patrick McHardy
2009-11-09 16:51               ` Johannes Berg
2009-11-09 16:57                 ` Patrick McHardy
2009-11-09 17:46                   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257497752.29454.11.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=j@w1.fi \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).