From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Sergey Lapin <slapin@ossfans.org>
Subject: [PATCH 07/17] ieee802154: constify struct net_device in some operations
Date: Fri, 6 Nov 2009 15:39:31 +0300 [thread overview]
Message-ID: <1257511181-19403-8-git-send-email-dbaryshkov@gmail.com> (raw)
In-Reply-To: <1257511181-19403-1-git-send-email-dbaryshkov@gmail.com>
Some of ieee802154 operations really shouldn't change passed net_device.
Constify passed argument.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
drivers/ieee802154/fakehard.c | 8 ++++----
include/net/ieee802154_netdev.h | 10 +++++-----
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/ieee802154/fakehard.c b/drivers/ieee802154/fakehard.c
index 4ea93cc..77fbb51 100644
--- a/drivers/ieee802154/fakehard.c
+++ b/drivers/ieee802154/fakehard.c
@@ -43,7 +43,7 @@ struct wpan_phy *net_to_phy(struct net_device *dev)
*
* Return the ID of the PAN from the PIB.
*/
-static u16 fake_get_pan_id(struct net_device *dev)
+static u16 fake_get_pan_id(const struct net_device *dev)
{
BUG_ON(dev->type != ARPHRD_IEEE802154);
@@ -58,7 +58,7 @@ static u16 fake_get_pan_id(struct net_device *dev)
* device. If the device has not yet had a short address assigned
* then this should return 0xFFFF to indicate a lack of association.
*/
-static u16 fake_get_short_addr(struct net_device *dev)
+static u16 fake_get_short_addr(const struct net_device *dev)
{
BUG_ON(dev->type != ARPHRD_IEEE802154);
@@ -78,7 +78,7 @@ static u16 fake_get_short_addr(struct net_device *dev)
* Note: This is in section 7.2.1.2 of the IEEE 802.15.4-2006
* document.
*/
-static u8 fake_get_dsn(struct net_device *dev)
+static u8 fake_get_dsn(const struct net_device *dev)
{
BUG_ON(dev->type != ARPHRD_IEEE802154);
@@ -98,7 +98,7 @@ static u8 fake_get_dsn(struct net_device *dev)
* Note: This is in section 7.2.1.2 of the IEEE 802.15.4-2006
* document.
*/
-static u8 fake_get_bsn(struct net_device *dev)
+static u8 fake_get_bsn(const struct net_device *dev)
{
BUG_ON(dev->type != ARPHRD_IEEE802154);
diff --git a/include/net/ieee802154_netdev.h b/include/net/ieee802154_netdev.h
index 5dc6a61..d23fb5a 100644
--- a/include/net/ieee802154_netdev.h
+++ b/include/net/ieee802154_netdev.h
@@ -98,14 +98,14 @@ struct ieee802154_mlme_ops {
* FIXME: these should become the part of PIB/MIB interface.
* However we still don't have IB interface of any kind
*/
- u16 (*get_pan_id)(struct net_device *dev);
- u16 (*get_short_addr)(struct net_device *dev);
- u8 (*get_dsn)(struct net_device *dev);
- u8 (*get_bsn)(struct net_device *dev);
+ u16 (*get_pan_id)(const struct net_device *dev);
+ u16 (*get_short_addr)(const struct net_device *dev);
+ u8 (*get_dsn)(const struct net_device *dev);
+ u8 (*get_bsn)(const struct net_device *dev);
};
static inline struct ieee802154_mlme_ops *ieee802154_mlme_ops(
- struct net_device *dev)
+ const struct net_device *dev)
{
return dev->ml_priv;
}
--
1.6.5
next prev parent reply other threads:[~2009-11-06 12:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 12:39 [NEXT PULL 00/17] IEEE 802.15.4 stack updates Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 01/17] wpan-phy: add a helper to put the wpan_phy device Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 02/17] wpan-phy: add wpan-phy iteration functions Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 03/17] wpan-phy: init channel/page fields Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 04/17] wpan-phy: use snprintf to limit the amount of chars written Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 05/17] wpan-phy: allow specifying a per-page channel mask Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 06/17] wpan-phy: follow usual patter of devices registration Dmitry Eremin-Solenikov
2009-11-06 12:39 ` Dmitry Eremin-Solenikov [this message]
2009-11-06 12:39 ` [PATCH 08/17] ieee802154: merge nl802154 and wpan-class in single module Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 09/17] ieee802154: split away MAC commands implementation Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 10/17] ieee802154: add LIST_PHY command support Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 11/17] fakehard: no need to export net_to_phy, make it static Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 12/17] fakehard: claim all 2.4 Ghz channels as supported Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 13/17] ieee802154: add an mlme_ops call to retrieve PHY object Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 14/17] fakehard: mlme_ops->get_phy implementation Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 15/17] ieee802154: add two nl802154 helpers Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 16/17] ieee802154: add PHY_NAME to LIST_IFACE command results Dmitry Eremin-Solenikov
2009-11-06 12:39 ` [PATCH 17/17] ieee802154: add support for creation/removal of logic interfaces Dmitry Eremin-Solenikov
2009-11-07 2:02 ` [NEXT PULL 00/17] IEEE 802.15.4 stack updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257511181-19403-8-git-send-email-dbaryshkov@gmail.com \
--to=dbaryshkov@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=slapin@ossfans.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).