* [PATCH 43/75] spider-net: declare MODULE_FIRMWARE
@ 2009-11-07 21:55 Ben Hutchings
2009-11-09 11:58 ` Jens Osterkamp
2009-11-11 4:33 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Ben Hutchings @ 2009-11-07 21:55 UTC (permalink / raw)
To: David Miller; +Cc: Ishizaki Kou, Jens Osterkamp, netdev
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
drivers/net/spider_net.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/spider_net.c b/drivers/net/spider_net.c
index 90e663f..782910c 100644
--- a/drivers/net/spider_net.c
+++ b/drivers/net/spider_net.c
@@ -57,6 +57,7 @@ MODULE_AUTHOR("Utz Bacher <utz.bacher@de.ibm.com> and Jens Osterkamp " \
MODULE_DESCRIPTION("Spider Southbridge Gigabit Ethernet driver");
MODULE_LICENSE("GPL");
MODULE_VERSION(VERSION);
+MODULE_FIRMWARE(SPIDER_NET_FIRMWARE_NAME);
static int rx_descriptors = SPIDER_NET_RX_DESCRIPTORS_DEFAULT;
static int tx_descriptors = SPIDER_NET_TX_DESCRIPTORS_DEFAULT;
--
1.6.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 43/75] spider-net: declare MODULE_FIRMWARE
2009-11-07 21:55 [PATCH 43/75] spider-net: declare MODULE_FIRMWARE Ben Hutchings
@ 2009-11-09 11:58 ` Jens Osterkamp
2009-11-11 4:35 ` David Miller
2009-11-11 4:33 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Jens Osterkamp @ 2009-11-09 11:58 UTC (permalink / raw)
To: Ben Hutchings; +Cc: David Miller, Ishizaki Kou, Jens Osterkamp, netdev, arnd
On Saturday 07 November 2009, Ben Hutchings wrote:
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> drivers/net/spider_net.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/spider_net.c b/drivers/net/spider_net.c
> index 90e663f..782910c 100644
> --- a/drivers/net/spider_net.c
> +++ b/drivers/net/spider_net.c
> @@ -57,6 +57,7 @@ MODULE_AUTHOR("Utz Bacher <utz.bacher@de.ibm.com> and
> Jens Osterkamp " \ MODULE_DESCRIPTION("Spider Southbridge Gigabit Ethernet
> driver"); MODULE_LICENSE("GPL");
> MODULE_VERSION(VERSION);
> +MODULE_FIRMWARE(SPIDER_NET_FIRMWARE_NAME);
>
> static int rx_descriptors = SPIDER_NET_RX_DESCRIPTORS_DEFAULT;
> static int tx_descriptors = SPIDER_NET_TX_DESCRIPTORS_DEFAULT;
In spider_net, the filesystem is checked for a valid firmware first, if it
does not exist, the firmware is taken from the device tree (which is the
default case).
Do you expect this behaviour to cause problems together with MODULE_FIRMWARE ?
--
Best regards,
Jens Osterkamp
--------------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Erich Baier
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 43/75] spider-net: declare MODULE_FIRMWARE
2009-11-09 11:58 ` Jens Osterkamp
@ 2009-11-11 4:35 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-11-11 4:35 UTC (permalink / raw)
To: jens; +Cc: ben, kou.ishizaki, jens, netdev, arnd
From: Jens Osterkamp <jens@linux.vnet.ibm.com>
Date: Mon, 9 Nov 2009 12:58:13 +0100
> In spider_net, the filesystem is checked for a valid firmware first, if it
> does not exist, the firmware is taken from the device tree (which is the
> default case).
>
> Do you expect this behaviour to cause problems together with MODULE_FIRMWARE ?
I think it should be OK.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 43/75] spider-net: declare MODULE_FIRMWARE
2009-11-07 21:55 [PATCH 43/75] spider-net: declare MODULE_FIRMWARE Ben Hutchings
2009-11-09 11:58 ` Jens Osterkamp
@ 2009-11-11 4:33 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2009-11-11 4:33 UTC (permalink / raw)
To: ben; +Cc: kou.ishizaki, jens, netdev
From: Ben Hutchings <ben@decadent.org.uk>
Date: Sat, 07 Nov 2009 21:55:07 +0000
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Applied to net-next-2.6
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-11 4:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-07 21:55 [PATCH 43/75] spider-net: declare MODULE_FIRMWARE Ben Hutchings
2009-11-09 11:58 ` Jens Osterkamp
2009-11-11 4:35 ` David Miller
2009-11-11 4:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).