From: jamal <hadi@cyberus.ca>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] act_mirred: don't go back.
Date: Tue, 10 Nov 2009 02:40:34 -0500 [thread overview]
Message-ID: <1257838834.3647.4.camel@bigi> (raw)
In-Reply-To: <412e6f7f0911090433j2b270663ycdf277110fbc6bac@mail.gmail.com>
I apologize - I am still not convinced this is a cleanup and i can
already see holes you are introducing (example not freeing skb etc).
You are putting me in a dilemma of not wanting to discourage you
but at the same time not seeing this as a useful change to be made.
Can we let this one slide?
cheers,
jamal
On Mon, 2009-11-09 at 20:33 +0800, Changli Gao wrote:
[..]
> How about this version.
>
> 1. move skb_act_clone() after all the necessary checks, and it can
> eliminate unnecessary skb_act_clone() if tcfm_eaction isn't correct.
> 2. there is one exit of the critical section.
> 3. jump forward instead of backward.
next prev parent reply other threads:[~2009-11-10 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 6:43 [PATCH] act_mirred: don't go back Changli Gao
2009-11-09 7:22 ` jamal
2009-11-09 8:31 ` Changli Gao
2009-11-09 10:54 ` jamal
2009-11-09 11:06 ` Changli Gao
2009-11-09 12:33 ` Changli Gao
2009-11-10 7:40 ` jamal [this message]
2009-11-10 8:50 ` Changli Gao
2009-11-11 8:11 ` jamal
2009-11-11 8:44 ` Changli Gao
2009-11-11 9:03 ` jamal
2009-11-11 9:23 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257838834.3647.4.camel@bigi \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).