From: jamal <hadi@cyberus.ca>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Stephen Hemminger <shemminger@vyatta.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] act_mirred: optimization
Date: Mon, 16 Nov 2009 05:06:30 -0500 [thread overview]
Message-ID: <1258365990.3251.33.camel@bigi> (raw)
In-Reply-To: <412e6f7f0911160153g31d5eado7c5569d9e95f7d01@mail.gmail.com>
On Mon, 2009-11-16 at 17:53 +0800, Changli Gao wrote:
Just one small comment; sorry, i missed this the first time:
> + if (dev == NULL)
> return -EINVAL;
> pc = tcf_hash_create(parm->index, est, a, sizeof(*m), bind,
> &mirred_idx_gen, &mirred_hash_info);
> if (IS_ERR(pc))
> - return PTR_ERR(pc);
> + return PTR_ERR(pc);
One indent too many?
cheers,
jamal
next prev parent reply other threads:[~2009-11-16 10:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 9:53 [PATCH 2/2] act_mirred: optimization Changli Gao
2009-11-16 10:06 ` jamal [this message]
2009-11-16 10:21 ` David Miller
2009-11-16 10:24 ` jamal
2009-11-16 10:48 ` David Miller
2009-11-16 10:58 ` David Miller
2009-11-16 13:05 ` Changli Gao
2009-11-16 13:17 ` David Miller
2009-11-16 13:22 ` Changli Gao
2009-11-16 13:33 ` David Miller
2009-11-17 5:49 ` Changli Gao
2009-11-17 12:16 ` David Miller
2009-11-16 13:27 ` Jarek Poplawski
-- strict thread matches above, loose matches on Subject: below --
2009-11-16 8:56 Changli Gao
2009-11-16 9:29 ` jamal
2009-11-16 9:40 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258365990.3251.33.camel@bigi \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).