From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [net-next-2.6 PATCH 1/2] ethtool: Add PHY type to ethtool get_drvinfo Date: Wed, 18 Nov 2009 01:23:41 +0000 Message-ID: <1258507421.2810.14.camel@localhost> References: <20091117161309.11341.9165.stgit@localhost.localdomain> <20091117090719.7d83492a@nehalam> <20091117164104.5da05b81@nehalam> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "Waskiewicz Jr, Peter P" , "Kirsher, Jeffrey T" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "gospo@redhat.com" To: Stephen Hemminger Return-path: Received: from mail.solarflare.com ([216.237.3.220]:35176 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbZKRBXs (ORCPT ); Tue, 17 Nov 2009 20:23:48 -0500 In-Reply-To: <20091117164104.5da05b81@nehalam> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2009-11-17 at 16:41 -0800, Stephen Hemminger wrote: > On Tue, 17 Nov 2009 11:56:57 -0800 (Pacific Standard Time) > "Waskiewicz Jr, Peter P" wrote: > > > On Tue, 17 Nov 2009, Stephen Hemminger wrote: > > > > > On Tue, 17 Nov 2009 08:13:24 -0800 > > > Jeff Kirsher wrote: > > > > > > > From: PJ Waskiewicz > > > > > > > > Allow the PHY type to be passed from a driver to ethtool when > > > > ethtool -i ethX is called. With newer network cards having SFP > > > > and SFP+ PHY cages, this information can be useful, especially > > > > if the NIC supports hot-swapping of the PHY modules. > > > > > > > > Signed-off-by: Peter P Waskiewicz Jr > > > > Signed-off-by: Jeff Kirsher > > > > --- > > > > > > Maybe revive usage of connector port in ethtool rather than adding new API? > > > It is already there but values are out of date with current hardware. > > > > You're referring to the MODE_GSET port settings? If so, I like this > > approach, and will update my patches accordingly. > > Yes. cmd->port is always PORT_TP or PORT_FIBRE now but could be extended > Likewise cmd->transceiver could be modified. I haven't seen an external transceiver > since the old fat yellow cable with vampire taps (and that was 20 yrs ago). It seems to me there should be a transceiver type code or codes for connectors like SFP where the bulk of the transceiver is internal but the optical part is an external module. SFP+ is a tricky case because it also supports passive cables. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.