netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shirley Ma <mashirle@us.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Avi Kivity <avi@redhat.com>,
	netdev@vger.kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Defer skb allocation for both mergeable buffers and big packets in virtio_net
Date: Mon, 23 Nov 2009 11:01:46 -0800	[thread overview]
Message-ID: <1259002906.5022.36.camel@localhost.localdomain> (raw)
In-Reply-To: <200911231138.30755.rusty@rustcorp.com.au>

Hello Rusty,

On Mon, 2009-11-23 at 11:38 +1030, Rusty Russell wrote:
> Overall, the patch looks good.  But it would have been nicer if it
> were
> split into several parts: cleanups, new infrastructure, then the
> actual
> allocation change.

I have split the patch into a set: cleanups, new infrastructure, and
actual allocation change in add buffers: add_recvbuf_big,
add_recvbuf_small, add_recvbuf_mergeage per your suggestion, and also in
recv buffers: recv_big, recv_small, recv_mergeable.

I hope you will agree with it. I am testing the patch-set now, will
submit it soon after finishing all test cases.

Thanks
Shirley


  parent reply	other threads:[~2009-11-23 19:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20  6:15 [PATCH 1/1] Defer skb allocation for both mergeable buffers and big packets in virtio_net Shirley Ma
2009-11-20  6:19 ` Eric Dumazet
2009-11-20 16:08   ` Shirley Ma
2009-11-20 16:21   ` Shirley Ma
2009-11-23  1:08     ` Rusty Russell
2009-11-23 16:07       ` Shirley Ma
2009-11-23 22:24         ` Rusty Russell
2009-11-23 23:27           ` Shirley Ma
2009-11-24 11:37           ` Michael S. Tsirkin
2009-11-24 14:36             ` Anthony Liguori
2009-11-24 16:04               ` Michael S. Tsirkin
2009-11-24 16:04               ` Michael S. Tsirkin
2009-11-25  0:15               ` Rusty Russell
2009-11-25  0:12             ` Rusty Russell
2009-11-25  9:15               ` Michael S. Tsirkin
2009-11-25 10:20                 ` Rusty Russell
2009-11-25 11:40                   ` Michael S. Tsirkin
2009-11-23 19:01       ` Shirley Ma [this message]
2009-11-23  9:43     ` Michael S. Tsirkin
2009-11-23 16:18       ` Shirley Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259002906.5022.36.camel@localhost.localdomain \
    --to=mashirle@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).