From: Ben Hutchings <ben@decadent.org.uk>
To: Jie Yang <jie.yang@atheros.com>
Cc: 558426@bugs.debian.org, netdev <netdev@vger.kernel.org>
Subject: TSOv6 broken in atl1e
Date: Tue, 01 Dec 2009 03:19:39 +0000 [thread overview]
Message-ID: <1259637579.3709.196.camel@localhost> (raw)
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
I received a bug report <http://bugs.debian.org/558426> that shows atl1e
corrupting IPv6 packets. I have reproduced this on an Eee PC 901 and
found that it is linked to TSO. The most obvious thing wrong with the
driver code is that it calculates the super-packet length incorrectly.
However, fixing that:
--- a/drivers/net/atl1e/atl1e_main.c
+++ b/drivers/net/atl1e/atl1e_main.c
@@ -1667,6 +1667,7 @@ static int atl1e_tso_csum(struct atl1e_adapter *adapter,
if (offload_type & SKB_GSO_TCPV6) {
real_len = (((unsigned char *)ipv6_hdr(skb) - skb->data)
+ + sizeof(struct ipv6hdr)
+ ntohs(ipv6_hdr(skb)->payload_len));
if (real_len < skb->len)
pskb_trim(skb, real_len);
--- END ---
does not solve the problem. Presumably this function is not
constructing correct DMA descriptors for TSOv6.
Please fix this, or I will submit a patch to remove this feature from
the driver.
Ben.
--
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next reply other threads:[~2009-12-01 3:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 3:19 Ben Hutchings [this message]
2009-12-01 5:17 ` TSOv6 broken in atl1e Jie Yang
2009-12-02 2:24 ` Jie Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259637579.3709.196.camel@localhost \
--to=ben@decadent.org.uk \
--cc=558426@bugs.debian.org \
--cc=jie.yang@atheros.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).