netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org
Subject: Re: Netlink event for network device statistics
Date: Tue, 01 Dec 2009 14:36:14 +0100	[thread overview]
Message-ID: <1259674574.4421.15.camel@violet> (raw)
In-Reply-To: <4B14FDFB.7060600@trash.net>

Hi Patrick,

> > so I was playing with monitoring network device statistics and storing
> > them over a period of time. While netlink and ethtool provides all the
> > network packet statistics, I have a problem with devices that are
> > actually hotplug. Especially 3G cards that get taken off the bus via
> > RFKILL and external dongles that can be unplugged at any time.
> > 
> > So I was thinking that before we send the DELLINK netlink event for that
> > interface, we should send the latest statistic details via netlink. Is
> > that a good idea or is there another way to get up-to-date statistics
> > without polling for them?
> 
> Don't we already include them in the DELLINK message? rtnl_fill_ifinfo()
> unconditionally includes the statistics.

you are correct. We already have the IFLA_STATS in DELLINK. I got
confused with ip monitor not decoding these and assumed they were not
included at all.

Regards

Marcel



      reply	other threads:[~2009-12-01 13:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-29 22:56 Netlink event for network device statistics Marcel Holtmann
2009-12-01 11:28 ` Patrick McHardy
2009-12-01 13:36   ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259674574.4421.15.camel@violet \
    --to=marcel@holtmann.org \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).