From: Ben Hutchings <bhutchings@solarflare.com>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Jeff Garzik <jeff@garzik.org>, netdev@vger.kernel.org
Subject: Re: [PATCH] Update embedded copy of ethtool.h from kernel 2.6.30
Date: Tue, 01 Dec 2009 15:21:18 +0000 [thread overview]
Message-ID: <1259680878.2831.3.camel@achroite.uk.solarflarecom.com> (raw)
In-Reply-To: <20091201151750.GG5694@axis.com>
On Tue, 2009-12-01 at 16:17 +0100, Jesper Nilsson wrote:
> Commit 0c09c1a49cc7b819b33566a49d9901f7cfdd6889 in the Linux kernel
> added a new field mdio_support inside the struct ethtool_cmd,
> changing the struct size for architectures that does not pad structs.
> (for example the CRIS architecture)
CRIS has no alignment requirements?! Wow. Sorry for changing the
structure, then.
> This size mismatch lead to the ethtool_cmd struct being written
> as 44 bytes in the kernel, but only 43 bytes allocated on stack,
> overwriting one byte in the stack frame.
>
> Update the ethtool copy of the definition to match the 2.6.30 kernel.
[...]
This has already been done.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-12-01 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 15:17 [PATCH] Update embedded copy of ethtool.h from kernel 2.6.30 Jesper Nilsson
2009-12-01 15:21 ` Ben Hutchings [this message]
2009-12-01 15:42 ` Jesper Nilsson
2009-12-01 15:52 ` Ben Hutchings
2009-12-01 15:54 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259680878.2831.3.camel@achroite.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=jeff@garzik.org \
--cc=jesper.nilsson@axis.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).