* [PATCH 2/3] atl1e: Remove redundant definitions of ethtool operations
@ 2009-12-02 5:10 Ben Hutchings
2009-12-03 6:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2009-12-02 5:10 UTC (permalink / raw)
To: David Miller; +Cc: Jie Yang, netdev
These functions provide the default behaviour and do not need to be
set in struct ethtool_ops.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
drivers/net/atl1e/atl1e_ethtool.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/drivers/net/atl1e/atl1e_ethtool.c b/drivers/net/atl1e/atl1e_ethtool.c
index b0fb725..bb15c51 100644
--- a/drivers/net/atl1e/atl1e_ethtool.c
+++ b/drivers/net/atl1e/atl1e_ethtool.c
@@ -131,11 +131,6 @@ static int atl1e_set_settings(struct net_device *netdev,
return 0;
}
-static u32 atl1e_get_tx_csum(struct net_device *netdev)
-{
- return (netdev->features & NETIF_F_HW_CSUM) != 0;
-}
-
static u32 atl1e_get_msglevel(struct net_device *netdev)
{
#ifdef DBG
@@ -393,13 +388,8 @@ static const struct ethtool_ops atl1e_ethtool_ops = {
.get_eeprom_len = atl1e_get_eeprom_len,
.get_eeprom = atl1e_get_eeprom,
.set_eeprom = atl1e_set_eeprom,
- .get_tx_csum = atl1e_get_tx_csum,
.set_tx_csum = ethtool_op_set_tx_hw_csum,
- .get_sg = ethtool_op_get_sg,
.set_sg = ethtool_op_set_sg,
-#ifdef NETIF_F_TSO
- .get_tso = ethtool_op_get_tso,
-#endif
.set_tso = ethtool_op_set_tso,
};
--
1.6.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] atl1e: Remove redundant definitions of ethtool operations
2009-12-02 5:10 [PATCH 2/3] atl1e: Remove redundant definitions of ethtool operations Ben Hutchings
@ 2009-12-03 6:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-12-03 6:15 UTC (permalink / raw)
To: ben; +Cc: jie.yang, netdev
From: Ben Hutchings <ben@decadent.org.uk>
Date: Wed, 02 Dec 2009 05:10:03 +0000
> These functions provide the default behaviour and do not need to be
> set in struct ethtool_ops.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-03 6:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-02 5:10 [PATCH 2/3] atl1e: Remove redundant definitions of ethtool operations Ben Hutchings
2009-12-03 6:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).