* [PATCH 3/3] atl1e: Remove non-implementation of ethtool set_msglevel() operation
@ 2009-12-02 5:10 Ben Hutchings
2009-12-03 6:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2009-12-02 5:10 UTC (permalink / raw)
To: David Miller; +Cc: Jie Yang, netdev
Unimplemented operations should not silently fail.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
drivers/net/atl1e/atl1e_ethtool.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/net/atl1e/atl1e_ethtool.c b/drivers/net/atl1e/atl1e_ethtool.c
index bb15c51..a76006c 100644
--- a/drivers/net/atl1e/atl1e_ethtool.c
+++ b/drivers/net/atl1e/atl1e_ethtool.c
@@ -140,10 +140,6 @@ static u32 atl1e_get_msglevel(struct net_device *netdev)
#endif
}
-static void atl1e_set_msglevel(struct net_device *netdev, u32 data)
-{
-}
-
static int atl1e_get_regs_len(struct net_device *netdev)
{
return AT_REGS_LEN * sizeof(u32);
@@ -382,7 +378,6 @@ static const struct ethtool_ops atl1e_ethtool_ops = {
.get_wol = atl1e_get_wol,
.set_wol = atl1e_set_wol,
.get_msglevel = atl1e_get_msglevel,
- .set_msglevel = atl1e_set_msglevel,
.nway_reset = atl1e_nway_reset,
.get_link = ethtool_op_get_link,
.get_eeprom_len = atl1e_get_eeprom_len,
--
1.6.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] atl1e: Remove non-implementation of ethtool set_msglevel() operation
2009-12-02 5:10 [PATCH 3/3] atl1e: Remove non-implementation of ethtool set_msglevel() operation Ben Hutchings
@ 2009-12-03 6:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-12-03 6:15 UTC (permalink / raw)
To: ben; +Cc: jie.yang, netdev
From: Ben Hutchings <ben@decadent.org.uk>
Date: Wed, 02 Dec 2009 05:10:18 +0000
> Unimplemented operations should not silently fail.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-03 6:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-02 5:10 [PATCH 3/3] atl1e: Remove non-implementation of ethtool set_msglevel() operation Ben Hutchings
2009-12-03 6:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).