tg3: not checking dma errors?

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

I'm having some trouble with tg3 under memory pressure when it's
receiving lots of data, and so far this is the only thing I could find
-- unfortunately I can't capture the debug information on the machine --
netconsole obviously doesn't work, there's no serial and the output
doesn't fit on the screen...

So I figured I'd look at the code, and now I think there could be a bug
with mappings:

tg3_alloc_rx_skb:
...
        mapping = pci_map_single(tp->pdev, skb->data, skb_size,
                                 PCI_DMA_FROMDEVICE);

        map->skb = skb;
        pci_unmap_addr_set(map, mapping, mapping);

        if (src_map != NULL)
                src_map->skb = NULL;

        desc->addr_hi = ((u64)mapping >> 32);
        desc->addr_lo = ((u64)mapping & 0xffffffff);

        return skb_size;



Shouldn't that check that 'mapping' is != DMA_ERROR_CODE?

Similarly in tg3_run_loopback()?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]